[PATCH] Fix for issue 3620 - revert command

2010-11-03 Thread Noorul Islam K M
Stefan Sperling writes: > > Noorul, if you're looking for more tasks, you could take a look at > issue #3620 which is about a similar problem: > http://subversion.tigris.org/issues/show_bug.cgi?id=3620 > I'll happily review and commit patches for issue #3620. > > Thanks, > Stefan Here is the pat

Re: [PATCH] introduce AuthzSVNRepoRelativeAccessFile configuration item for mod_authz_svn

2010-11-03 Thread Nick Piper
(This doesn't appear to have come through to the list after a day, so I'm resending it from a different MUA.) On 01/11/10 15:56, Philip Martin wrote: > The name should be AuthzSVNReposRelativeAccessFile for consistency with > SVNReposName. > > It should be an error to specify both AuthzSVNAccess

Re: [PATCH] Fix for issue 3620 - revert command

2010-11-03 Thread Stefan Sperling
On Wed, Nov 03, 2010 at 03:32:25PM +0530, Noorul Islam K M wrote: > > Stefan Sperling writes: > > > > Noorul, if you're looking for more tasks, you could take a look at > > issue #3620 which is about a similar problem: > > http://subversion.tigris.org/issues/show_bug.cgi?id=3620 > > I'll happily

Re: [PATCH] Fix for issue 3620 - revert command

2010-11-03 Thread Julian Foad
On Wed, 2010-11-03 at 14:46 +0100, Stefan Sperling wrote: > On Wed, Nov 03, 2010 at 03:32:25PM +0530, Noorul Islam K M wrote: > > > > Stefan Sperling writes: > > > > > > Noorul, if you're looking for more tasks, you could take a look at > > > issue #3620 which is about a similar problem: > > > ht

Re: [PATCH] Fix for issue 3620 - revert command

2010-11-03 Thread Stefan Sperling
On Wed, Nov 03, 2010 at 03:04:25PM +, Julian Foad wrote: > -0 on duplicating this check inside libsvn_client. The rationale is that our libraries should reject invalid input to prevent third party clients which pass invalid input from crashing. Clients passing a canonicalised path instead of a

Re: Fix for issue 3620 - revert command

2010-11-03 Thread Noorul Islam K M
Julian Foad writes: > On Wed, 2010-11-03 at 14:46 +0100, Stefan Sperling wrote: > >> On Wed, Nov 03, 2010 at 03:32:25PM +0530, Noorul Islam K M wrote: >> > >> > Stefan Sperling writes: >> > > >> > > Noorul, if you're looking for more tasks, you could take a look at >> > > issue #3620 which is a

Re: [PATCH] Fix for issue 3620 - revert command

2010-11-03 Thread Stefan Sperling
On Wed, Nov 03, 2010 at 04:22:57PM +0100, Stefan Sperling wrote: > On Wed, Nov 03, 2010 at 03:04:25PM +, Julian Foad wrote: > > -0 on duplicating this check inside libsvn_client. > > The rationale is that our libraries should reject invalid input > to prevent third party clients which pass inv

[PATCH] Fix for issue 3620 - resolve command

2010-11-03 Thread Noorul Islam K M
Log [[[ Make 'svn resolve' verify that none of its targets are URLs. * subversion/libsvn_client/resolved.c, subversion/svn/resolve-cmd.c (svn_client_resolve, svn_cl__resolve): Raise an error if any targets look like URLs. * subversion/tests/cmdline/input_validation_tests.py (invalid_r

Fix for issue 3620 - unlock command

2010-11-03 Thread Noorul Islam K M
Log [[[ Make 'svn unlock' verify that both working copy paths and URLs are not passed. * subversion/tests/cmdline/input_validation_tests.py (invalid_unlock_targets): New test, verifying that svn unlock copes well with invalid target combinations. * subversion/svn/unlock-cmd.c (svn_cl__

[PATCH] Fix for issue 3620 - resolved command

2010-11-03 Thread Noorul Islam K M
Log [[[ Make 'svn resolved' verify that none of its targets are URLs. * subversion/svn/resolved-cmd.c (svn_cl__resolved): Raise an error if any targets look like URLs. * subversion/tests/cmdline/input_validation_tests.py (invalid_resolved_targets, test_list): New test. Patch by: Noorul I

Re: [PATCH] Fix for issue 3620 - revert command

2010-11-03 Thread Julian Foad
On Wed, 2010-11-03 at 16:25 +0100, Stefan Sperling wrote: > On Wed, Nov 03, 2010 at 04:22:57PM +0100, Stefan Sperling wrote: > > On Wed, Nov 03, 2010 at 03:04:25PM +, Julian Foad wrote: > > > -0 on duplicating this check inside libsvn_client. > > > > The rationale is that our libraries should

Re: [PATCH] introduce AuthzSVNRepoRelativeAccessFile configuration item for mod_authz_svn

2010-11-03 Thread Philip Martin
Nick Piper writes: > New patch is: > > [[[ > Implement AuthzSVNReposRelativeAccessFile to allow SVNParentPath to use > a different authz configuration file for each repository. > > * subversion/mod_authz_svn/mod_authz_svn.c > (get_access_conf): Check if AuthzSVNReposRelativeAccessFile is used,

Re: make check-ctypes-python fails when executed from non src build direction

2010-11-03 Thread Julian Foad
On Mon, 2010-11-01 at 13:29 -0400, Greg Stein wrote: > On Mon, Nov 1, 2010 at 13:22, Jeremy Whitlock wrote: > >... > >>> subversion/bindings/ctypes-python/README still refers to setup.py. > >> > >> I think this is for those who are not using --with-ctypesgen option > >> while running configure scr

Re: [PATCH] Fix for issue 3620 - resolve command

2010-11-03 Thread Stefan Sperling
Thanks very much for the patch. Committed in r1030580. I made one tweak: On Wed, Nov 03, 2010 at 09:35:13PM +0530, Noorul Islam K M wrote: > Index: subversion/svn/resolve-cmd.c > === > --- subversion/svn/resolve-cmd.c (revision

Re: [PATCH] Fix for issue 3620 - resolved command

2010-11-03 Thread Stefan Sperling
On Wed, Nov 03, 2010 at 10:32:12PM +0530, Noorul Islam K M wrote: > > Log > > [[[ > > Make 'svn resolved' verify that none of its targets are URLs. > > * subversion/svn/resolved-cmd.c > (svn_cl__resolved): Raise an error if any targets look like URLs. > > * subversion/tests/cmdline/input_va

Re: Upgrading partially relocated working copies

2010-11-03 Thread C. Michael Pilato
On 10/19/2010 10:59 AM, Philip Martin wrote: > In 1.7 we insist that "switch --relocate" only acts on a whole working > copy. In 1.6 we allow parts of the working copy to be relocated. > What should 1.7 do when upgrading a partially switched working copy? > > At present it ignores partial relocat

Re: svn commit: r965892 - in /subversion/trunk: notes/dump-load-format.txt subversion/include/svn_repos.h subversion/libsvn_repos/dump.c

2010-11-03 Thread C. Michael Pilato
On 08/19/2010 04:42 PM, Stefan Sperling wrote: > On Thu, Jul 22, 2010 at 10:56:11AM -0400, C. Michael Pilato wrote: >> (And I will further suggest that we fix the dump.c code to pass FALSE for >> the 'force' parameter of svn_fs_file_checksum() calls, thus restoring the >> pre-Hyrums-change behavior

Re: [PATCH] Fix for issue 3620 - revert command

2010-11-03 Thread Stefan Sperling
On Wed, Nov 03, 2010 at 03:32:25PM +0530, Noorul Islam K M wrote: > Here is the patch for revert command. I will look into other commands as > and when time permits. > > Log > > [[[ > Make 'svn revert' verify that none of its targets are URLs. > > * subversion/libsvn_client/revert.c, > subver

Re: svn commit: r965892 - in /subversion/trunk: notes/dump-load-format.txt subversion/include/svn_repos.h subversion/libsvn_repos/dump.c

2010-11-03 Thread Stefan Sperling
On Wed, Nov 03, 2010 at 02:34:11PM -0400, C. Michael Pilato wrote: > On 08/19/2010 04:42 PM, Stefan Sperling wrote: > > On Thu, Jul 22, 2010 at 10:56:11AM -0400, C. Michael Pilato wrote: > >> (And I will further suggest that we fix the dump.c code to pass FALSE for > >> the 'force' parameter of svn

Re: svn commit: r965892 - in /subversion/trunk: notes/dump-load-format.txt subversion/include/svn_repos.h subversion/libsvn_repos/dump.c

2010-11-03 Thread Stefan Sperling
On Wed, Nov 03, 2010 at 08:13:54PM +0100, Stefan Sperling wrote: > On Wed, Nov 03, 2010 at 02:34:11PM -0400, C. Michael Pilato wrote: > > On 08/19/2010 04:42 PM, Stefan Sperling wrote: > > > On Thu, Jul 22, 2010 at 10:56:11AM -0400, C. Michael Pilato wrote: > > >> (And I will further suggest that w

Re: Fix for issue 3620 - unlock command

2010-11-03 Thread Noorul Islam K M
Noorul Islam K M writes: > Log > > [[[ > > Make 'svn unlock' verify that both working copy paths and URLs are > not passed. > > * subversion/tests/cmdline/input_validation_tests.py > (invalid_unlock_targets): New test, verifying that svn unlock copes well >with invalid target combinations.

Fix for issue 3620 - lock command

2010-11-03 Thread Noorul Islam K M
Log [[[ Make 'svn lock' verify that both working copy paths and URLs are not passed. * subversion/tests/cmdline/input_validation_tests.py (invalid_lock_targets): New test, verifying that svn lock copes well with invalid target combinations. * subversion/svn/lock-cmd.c (svn_cl__lock): F

Re: Fix for issue 3620 - unlock command

2010-11-03 Thread Stefan Sperling
On Thu, Nov 04, 2010 at 01:33:37AM +0530, Noorul Islam K M wrote: > Modified log message for the patch. > > Log > > [[[ > > Make 'svn unlock' verify that both working copy paths and URLs are > not passed. > > * subversion/tests/cmdline/input_validation_tests.py > (invalid_unlock_targets): Ne

Re: Fix for issue 3620 - unlock command

2010-11-03 Thread Stefan Sperling
On Wed, Nov 03, 2010 at 09:12:41PM +0100, Stefan Sperling wrote: > $ svn lock blah ^/ > subversion/libsvn_client/cmdline.c:330: (apr_err=235000) > svn: In file 'subversion/libsvn_subr/dirent_uri.c' line 1649: assertion > failed (! svn_path_is_url(relative)) > Abort trap (core dumped) Ooops, this

Re: Fix for issue 3620 - lock command

2010-11-03 Thread Noorul Islam K M
Noorul Islam K M writes: > Log > > [[[ > > Make 'svn lock' verify that both working copy paths and URLs are > not passed. > > * subversion/tests/cmdline/input_validation_tests.py > (invalid_lock_targets): New test, verifying that svn lock copes well >with invalid target combinations. > > *

Re: svn commit: r1030637 - /subversion/trunk/subversion/libsvn_repos/dump.c

2010-11-03 Thread C. Michael Pilato
On 11/03/2010 04:01 PM, s...@apache.org wrote: > Author: stsp > Date: Wed Nov 3 20:01:38 2010 > New Revision: 1030637 > > URL: http://svn.apache.org/viewvc?rev=1030637&view=rev > Log: > * subversion/libsvn_repos/dump.c > (dump_node): Don't force creation of checksums for file content. >The

Re: Fix for issue 3620 - lock command

2010-11-03 Thread Stefan Sperling
On Thu, Nov 04, 2010 at 02:14:32AM +0530, Noorul Islam K M wrote: > Sending updated patch with libsvn_client modifications. Thanks, r1030704. I've tweaked the log message slightly. Stefan

[Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-03 Thread Stefan Fuhrmann
Hi there, after stumbling twice over this issue, I ran grep and found that the current usage of svn_tristate_t does not depend on the actual numerical values used for its states. Therefore, I propose to define svn_tristate_false equal to FALSE and svn_tristate_true equal to TRUE. That way, we ca

Re: svn commit: r1029038 - /subversion/branches/performance/subversion/libsvn_subr/svn_string.c

2010-11-03 Thread Stefan Fuhrmann
On 30.10.2010 18:43, Daniel Shahaf wrote: Stefan Fuhrmann wrote on Sat, Oct 30, 2010 at 17:57:58 +0200: o.k. I now wrote my own filter to cope with the 618 "standard warnings": #!/bin/sh (make -j> /dev/null) 2>&1 | grep -v " In function " | grep -v " in statically " | grep -v " is deprecated "

Re: svn commit: r986453 - /subversion/branches/performance/subversion/libsvn_subr/subst.c

2010-11-03 Thread Stefan Fuhrmann
On 30.10.2010 20:30, Daniel Shahaf wrote: stef...@apache.org wrote on Tue, Aug 17, 2010 at 19:04:21 -: Author: stefan2 Date: Tue Aug 17 19:04:21 2010 New Revision: 986453 URL: http://svn.apache.org/viewvc?rev=986453&view=rev Log: Speed up EOF and keyword translation in two ways. First, don

Re: svn commit: r986453 - /subversion/branches/performance/subversion/libsvn_subr/subst.c

2010-11-03 Thread Julian Foad
On Thu, 2010-11-04, Stefan Fuhrmann wrote: > On 30.10.2010 20:30, Daniel Shahaf wrote: > > stef...@apache.org wrote on Tue, Aug 17, 2010 at 19:04:21 -: [...] > >> + /* Found an interesting char or EOF in the next 4 bytes. > >> + Find its exact position. */ > >> +

Re: Fix for issue 3620 - unlock command

2010-11-03 Thread Noorul Islam K M
Stefan Sperling writes: > On Wed, Nov 03, 2010 at 09:12:41PM +0100, Stefan Sperling wrote: > >> $ svn lock blah ^/ >> subversion/libsvn_client/cmdline.c:330: (apr_err=235000) >> svn: In file 'subversion/libsvn_subr/dirent_uri.c' line 1649: assertion >> failed (! svn_path_is_url(relative)) >> Abo

[PATCH] Fix for issue 3620 - status command

2010-11-03 Thread Noorul Islam K M
Log [[[ Make 'svn revert' verify that none of its targets are URLs. * subversion/libsvn_client/status.c, subversion/svn/status-cmd.c (svn_client_status5, svn_cl__status): Raise an error if any targets look like URLs. * subversion/tests/cmdline/input_validation_tests.py (invalid_status

Re: Fix for issue 3620 - status command

2010-11-03 Thread Noorul Islam K M
Noorul Islam K M writes: > Log > > [[[ > > Make 'svn revert' verify that none of its targets are URLs. > > * subversion/libsvn_client/status.c, > subversion/svn/status-cmd.c > (svn_client_status5, svn_cl__status): Raise an error if any targets > look like URLs. > > * subversion/tests/cmdli