Re: Bikeshed: configuration override order

2010-08-11 Thread Julian Foad
On Tue, 2010-08-10, C. Michael Pilato wrote: > On 08/10/2010 01:25 PM, Julian Foad wrote: > > Oh? All I know about Andrew's particular requirements related to this > > query is what's quoted above - "If I ... accidentally leave the banned > > buildlog.htm file in ..." - which sounded vaguely like

Re: Bug in svn_fs_paths_changed2() Python bindings?

2010-08-11 Thread Alexey Neyman
Small update to the patch: change doxygen comment to match new argument name. Regards, Alexey. On Tuesday, August 10, 2010 02:53:50 pm Alexey Neyman wrote: > Hi all, > > Looks like the binding for svn_fs_paths_changed2() incorrectly specifies > the type of structures contained in the hash it ret

Re: svn commit: r984208 - /subversion/branches/ignore-mergeinfo/subversion/libsvn_client/status.c

2010-08-11 Thread Julian Foad
On Tue, 2010-08-10, hwri...@apache.org wrote: > Author: hwright > Date: Tue Aug 10 20:59:29 2010 > New Revision: 984208 > > URL: http://svn.apache.org/viewvc?rev=984208&view=rev > Log: > On the ignore-mergeinfo branch: > Fix a cast which was causing a segfault in stat test 32 as a result of the >

Re: svn commit: r984007 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2010-08-11 Thread Julian Foad
On Tue, 2010-08-10, rhuij...@apache.org wrote: > Author: rhuijben > Date: Tue Aug 10 13:46:57 2010 > New Revision: 984007 > > URL: http://svn.apache.org/viewvc?rev=984007&view=rev > Log: > * subversion/libsvn_wc/update_editor.c > (cleanup_dir_baton): When calling wq_run() from pool cleanup, don'

RE: Bikeshed: configuration override order

2010-08-11 Thread Bolstridge, Andrew
> -Original Message- > From: Julian Foad [mailto:julian.f...@wandisco.com] > Sent: Tuesday, August 10, 2010 6:25 PM > To: C. Michael Pilato > Cc: Bolstridge, Andrew; Subversion Development > Subject: Re: Bikeshed: configuration override order > [snip] > > Oh? All I know about Andrew's p

Re: Bikeshed: configuration override order

2010-08-11 Thread Branko Čibej
On 11.08.2010 11:05, Bolstridge, Andrew wrote: > The second aspect: client-stored passwords, this isn't so much about storing > them on the client but about having different ones. Enterprises want > single-signon, ie, a single password, centrally held, that is used for all > apps. They don't rea

Re: Looking to improve performance of svn annotate

2010-08-11 Thread Julian Foad
On Wed, 2010-08-11, Johan Corveleyn wrote: > Hi all, > > Other priorities have unfortunately kept me from focusing on the > project of speeding up blame. But recently I've spent some time > thinking about it, reading the other mail threads, studying the code > and profiling a little bit. I hope I

Re: [atomic-revprops] status update

2010-08-11 Thread Stefan Sperling
On Wed, Aug 11, 2010 at 03:51:38AM +0300, Daniel Shahaf wrote: > (hitted "send" too soon) > > Daniel Shahaf wrote on Wed, Aug 11, 2010 at 03:40:51 +0300: > > For the last few weeks I've been working on the atomic-revprop branch. > > > > (Its goal is port the new svn_fs_change_rev_prop2() to libsv

Re: Bikeshed: configuration override order

2010-08-11 Thread Stefan Sperling
On Tue, Aug 10, 2010 at 11:12:25PM +0200, Branko Čibej wrote: > The issue isn't storing passwords, but storing them insecurely, i.e., in > plaintext on disk. Which is what Subversion does by default unless it Not "by default" anymore. As of 1.6.0, the default is to *ask* the user whether storing p

Re: [atomic-revprops] status update

2010-08-11 Thread Julian Foad
On Wed, 2010-08-11, Stefan Sperling wrote: > The BRANCH-README suggest that we add an interface like > 'svn propedit --revprop pname pval2 --old-value=pval'. > I don't think there is a valid use case for non-atomic revprop changes. > Why not just make all revprop changes atomic by default if the

Re: NOTICE: Testing over ra-dav has changed in trunk!!

2010-08-11 Thread Julian Foad
On Tue, 2010-08-10, C. Michael Pilato wrote: > Per the commit's log message: > > On 08/10/2010 09:38 PM, cmpil...@apache.org wrote: > > Author: cmpilato > > Date: Wed Aug 11 01:38:40 2010 > > New Revision: 984280 > > [...] > > > NOTE: The test suite changes brought in by this merge require > >

RE: NOTICE: Testing over ra-dav has changed in trunk!!

2010-08-11 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julian.f...@wandisco.com] > Sent: woensdag 11 augustus 2010 12:41 > To: C. Michael Pilato > Cc: dev@subversion.apache.org; cmpil...@apache.org; > comm...@subversion.apache.org > Subject: Re: NOTICE: Testing over ra-dav has changed in trunk!

RE: Bikeshed: configuration override order

2010-08-11 Thread Bolstridge, Andrew
> -Original Message- > From: Branko Čibej [mailto:br...@xbc.nu] > Sent: Wednesday, August 11, 2010 10:37 AM > To: dev@subversion.apache.org > Subject: Re: Bikeshed: configuration override order > > On 11.08.2010 11:05, Bolstridge, Andrew wrote: > > The second aspect: client-stored password

Re: [atomic-revprops] status update

2010-08-11 Thread Daniel Shahaf
Julian Foad wrote on Wed, Aug 11, 2010 at 11:33:49 +0100: > On Wed, 2010-08-11, Stefan Sperling wrote: > > The BRANCH-README suggest that we add an interface like > > 'svn propedit --revprop pname pval2 --old-value=pval'. > > I don't think there is a valid use case for non-atomic revprop changes.

RE: NOTICE: Testing over ra-dav has changed in trunk!!

2010-08-11 Thread Julian Foad
Bert Huijben wrote: > From: Julian Foad [mailto:julian.f...@wandisco.com] > > > > NOTE: The test suite changes brought in by this merge require > > > > modifications to developers' httpd.conf files. So if you see the > > > > redirect_tests.py all failing, make sure you've updated your Apache > >

Re: svn commit: r984208 - /subversion/branches/ignore-mergeinfo/subversion/libsvn_client/status.c

2010-08-11 Thread Hyrum Wright
On Wed, Aug 11, 2010 at 3:15 AM, Julian Foad wrote: > On Tue, 2010-08-10, hwri...@apache.org wrote: >> Author: hwright >> Date: Tue Aug 10 20:59:29 2010 >> New Revision: 984208 >> >> URL: http://svn.apache.org/viewvc?rev=984208&view=rev >> Log: >> On the ignore-mergeinfo branch: >> Fix a cast whic

Re: Bikeshed: configuration override order

2010-08-11 Thread Hyrum K. Wright
On Wed, Aug 11, 2010 at 6:05 AM, Bolstridge, Andrew wrote: >> -Original Message- >> From: Branko Čibej [mailto:br...@xbc.nu] >> Sent: Wednesday, August 11, 2010 10:37 AM >> To: dev@subversion.apache.org >> Subject: Re: Bikeshed: configuration override order >> >> On 11.08.2010 11:05, Bolst

RE: Bikeshed: configuration override order

2010-08-11 Thread Bob Archer
> On 11.08.2010 11:05, Bolstridge, Andrew wrote: > > The second aspect: client-stored passwords, this isn't so much > about storing them on the client but about having different ones. > Enterprises want single-signon, ie, a single password, centrally > held, that is used for all apps. They don't re

RE: Bikeshed: configuration override order

2010-08-11 Thread Bert Huijben
> -Original Message- > From: Bob Archer [mailto:bob.arc...@amsi.com] > Sent: woensdag 11 augustus 2010 15:42 > To: Branko Čibej; dev@subversion.apache.org > Subject: RE: Bikeshed: configuration override order > > > On 11.08.2010 11:05, Bolstridge, Andrew wrote: > > > The second aspect: c

Re: Looking to improve performance of svn annotate

2010-08-11 Thread Greg Hudson
On Wed, 2010-08-11 at 06:04 -0400, Julian Foad wrote: > Ah. An interesting point which I hadn't fully digested. I think the > gist of Branko's point is that the delta format doesn't distinguish > between In the process of a blame operation, the server is already performing binary deltas (which a

Re: svn commit: r984280 - in /subversion/trunk: ./ subversion/include/ subversion/libsvn_client/ subversion/libsvn_ra/ subversion/libsvn_ra_local/ subversion/libsvn_ra_neon/ subversion/libsvn_ra_ser

2010-08-11 Thread C. Michael Pilato
On 08/10/2010 10:07 PM, Hyrum K. Wright wrote: >> Added: >>subversion/trunk/BRANCH-README > > Did you mean to bring this over with the merge? Oh. Heh. Nope. I repeated and reverted that reintegration several times (because I kept finding bugs that needed fixin' on the branch), too. It fig

Re: [PATCH] Bug in svn_fs_paths_changed2() Python bindings?

2010-08-11 Thread C. Michael Pilato
On 08/10/2010 09:22 PM, Alexey Neyman wrote: > Okay, try again: > > [[[ > Fix the type of structures returned in bindings from svn_fs_paths_changed2(). > > * subversion/include/svn_fs.h > (svn_fs_paths_changed2): Rename the argument from changed_paths_p to > changed_paths_p2, so that it's dif

Re: svn commit: r984007 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2010-08-11 Thread Greg Stein
I think you *always* want wq operations to be cancelable. That simply means that wq items will be left behind and "svn cleanup" will fix it. I see no problem with that. Cheers, -g On Tue, Aug 10, 2010 at 09:46, wrote: > Author: rhuijben > Date: Tue Aug 10 13:46:57 2010 > New Revision: 984007 >

RE: svn commit: r984007 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2010-08-11 Thread Bert Huijben
> -Original Message- > From: Greg Stein [mailto:gst...@gmail.com] > Sent: woensdag 11 augustus 2010 21:30 > To: dev@subversion.apache.org > Subject: Re: svn commit: r984007 - > /subversion/trunk/subversion/libsvn_wc/update_editor.c > > I think you *always* want wq operations to be cancel

Re: svn commit: r984007 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2010-08-11 Thread Greg Stein
On Wed, Aug 11, 2010 at 15:47, Bert Huijben wrote: >> -Original Message- >> From: Greg Stein [mailto:gst...@gmail.com] >> Sent: woensdag 11 augustus 2010 21:30 >> To: dev@subversion.apache.org >> Subject: Re: svn commit: r984007 - >> /subversion/trunk/subversion/libsvn_wc/update_editor.c >

Re: [PATCH] Bug in svn_fs_paths_changed2() Python bindings?

2010-08-11 Thread C. Michael Pilato
On 08/11/2010 03:10 PM, C. Michael Pilato wrote: > On 08/10/2010 09:22 PM, Alexey Neyman wrote: >> Okay, try again: >> >> [[[ >> Fix the type of structures returned in bindings from svn_fs_paths_changed2(). >> >> * subversion/include/svn_fs.h >> (svn_fs_paths_changed2): Rename the argument from c

Re: [PATCH] Bug in svn_fs_paths_changed2() Python bindings?

2010-08-11 Thread Alexey Neyman
On Wednesday, August 11, 2010 12:10:41 pm C. Michael Pilato wrote: > On 08/10/2010 09:22 PM, Alexey Neyman wrote: > > Okay, try again: > > > > [[[ > > Fix the type of structures returned in bindings from > > svn_fs_paths_changed2(). > > > > * subversion/include/svn_fs.h > > > > (svn_fs_paths_c

Re: Looking to improve performance of svn annotate

2010-08-11 Thread Johan Corveleyn
Thanks for the input/explanations, Julian and Greg. Some reactions below ... On Wed, Aug 11, 2010 at 12:04 PM, Julian Foad wrote: [...] > I hadn't really appreciated this difficulty. By noticing the copy > source positions when interpreting the delta, we might be able to do > better: > > cp fro

Re: Looking to improve performance of svn annotate

2010-08-11 Thread Greg Hudson
On Wed, 2010-08-11 at 19:14 -0400, Johan Corveleyn wrote: > I naively thought that the server, upon being called get_file_revs2, > would just supply the deltas which it has already stored in the > repository. I.e. that the deltas are just the native format in which > the stuff is kept in the back-e

Re: svnrdump: The BIG update

2010-08-11 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > > It's been a few weeks since I got partial committer access, and ~80 > > commits later, this is what we have: > > > > Firstly, thanks to Daniel for motivating me and driving me to submit > > the series to the list, and guiding me through everything. Without > >