Re: svn commit: r927211 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-03-25 Thread Philip Martin
rdo...@apache.org writes: > Author: rdonch > Date: Wed Mar 24 22:39:24 2010 > New Revision: 927211 > > URL: http://svn.apache.org/viewvc?rev=927211&view=rev > Log: > * subversion/libsvn_wc/wc_db.c: > (svn_wc__db_wclock_set): Pass levels_to_lock to svn_sqlite__bindf >as a 64-bit value, as req

Re: svn commit: r927211 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-03-25 Thread Julian Foad
Philip Martin wrote: > rdo...@apache.org writes: > > > Author: rdonch > > Date: Wed Mar 24 22:39:24 2010 > > New Revision: 927211 > > > > URL: http://svn.apache.org/viewvc?rev=927211&view=rev > > Log: > > * subversion/libsvn_wc/wc_db.c: > > (svn_wc__db_wclock_set): Pass levels_to_lock to svn_sql

Re: svn commit: r927211 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-03-25 Thread Philip Martin
Julian Foad writes: > But that would obscure the reason for it and "int levels_to_lock" is the > API idiom throughout Subversion. OK. I've just noticed that every caller of svn_wc__db_wclock_set passes zero for levels_to_lock, perhaps it doesn't need to be a parameter at all. -- Philip

Re: svn commit: r927211 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-03-25 Thread Hyrum K. Wright
On Mar 25, 2010, at 7:06 AM, Philip Martin wrote: > Julian Foad writes: > >> But that would obscure the reason for it and "int levels_to_lock" is the >> API idiom throughout Subversion. > > OK. I've just noticed that every caller of svn_wc__db_wclock_set > passes zero for levels_to_lock, perh

Re: svn commit: r927211 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-03-25 Thread Julian Foad
Hyrum K. Wright wrote: > On Mar 25, 2010, at 7:06 AM, Philip Martin wrote: > > OK. I've just noticed that every caller of svn_wc__db_wclock_set > > passes zero for levels_to_lock, perhaps it doesn't need to be a > > parameter at all. > > This is here strictly for backward compat. The access bato

Re: svn commit: r927344 - in /subversion/trunk/subversion/libsvn_wc: upgrade.c wc_db.c

2010-03-25 Thread Greg Stein
On Thu, Mar 25, 2010 at 07:03, wrote: >... > * subversion/libsvn_wc/wc_db.c >  (insert_base_node, svn_wc__db_op_set_last_mod_time): Pass integers to >    svn_sqlite__bindf as 64-bit values, as required by the latter.  (The >    first one here is typedef'd to 'long int' which may not be the same o

Re: svn commit: r927211 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-03-25 Thread Greg Stein
On Thu, Mar 25, 2010 at 09:06, Julian Foad wrote: > Hyrum K. Wright wrote: >> On Mar 25, 2010, at 7:06 AM, Philip Martin wrote: >> > OK.  I've just noticed that every caller of svn_wc__db_wclock_set >> > passes zero for levels_to_lock, perhaps it doesn't need to be a >> > parameter at all. >> >> T

Re: svn commit: r927211 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-03-25 Thread Julian Foad
Greg Stein wrote: > On Thu, Mar 25, 2010 at 09:06, Julian Foad wrote: > > Hyrum K. Wright wrote: > >> On Mar 25, 2010, at 7:06 AM, Philip Martin wrote: > >> > OK. I've just noticed that every caller of svn_wc__db_wclock_set > >> > passes zero for levels_to_lock, perhaps it doesn't need to be a >

Re: svn commit: r927344 - in /subversion/trunk/subversion/libsvn_wc: upgrade.c wc_db.c

2010-03-25 Thread Julian Foad
Greg Stein wrote: > On Thu, Mar 25, 2010 at 07:03, wrote: > >... > > * subversion/libsvn_wc/wc_db.c > > (insert_base_node, svn_wc__db_op_set_last_mod_time): Pass integers to > >svn_sqlite__bindf as 64-bit values, as required by the latter. (The > >first one here is typedef'd to 'long in

Re: svn commit: r927412 - /subversion/trunk/subversion/libsvn_client/export.c

2010-03-25 Thread Greg Stein
Please revert. I'm working on fixing this properly. On Thu, Mar 25, 2010 at 10:10, wrote: > Author: stylesen > Date: Thu Mar 25 14:10:11 2010 > New Revision: 927412 > > URL: http://svn.apache.org/viewvc?rev=927412&view=rev > Log: > Follow up r921604. Fix failing export test 11. > > * subversion/

Re: svn commit: r927412 - /subversion/trunk/subversion/libsvn_client/export.c

2010-03-25 Thread Greg Stein
Reverted in r927460. On Thu, Mar 25, 2010 at 10:53, Greg Stein wrote: > Please revert. I'm working on fixing this properly. > > On Thu, Mar 25, 2010 at 10:10,   wrote: >> Author: stylesen >> Date: Thu Mar 25 14:10:11 2010 >> New Revision: 927412 >> >> URL: http://svn.apache.org/viewvc?rev=927412&