Re: swig-py3 svn_stream_read

2018-03-24 Thread Daniel Shahaf
Troy Curtis Jr wrote on Fri, Mar 23, 2018 at 11:09:42 +: > On Fri, Mar 23, 2018, 3:10 AM Daniel Shahaf wrote: > > — shouldn't svn_stream_read() return bytes under py3? > > > > Yes, I would say that bytes is absolutely the right thing to return here > since svn_stream is an arbitrary byte int

Re: swig-py3 svn_stream_read

2018-03-23 Thread Troy Curtis Jr
On Fri, Mar 23, 2018, 3:10 AM Daniel Shahaf wrote: > Trying to merge trunk@HEAD into branches/swig-py3, the py2 tests pass > but the py3 tests fail: > > [[[ > E/usr/lib/python3.5/unittest/case.py:629: > ResourceWarning: unclosed file <_io.BufferedWriter

swig-py3 svn_stream_read

2018-03-23 Thread Daniel Shahaf
Trying to merge trunk@HEAD into branches/swig-py3, the py2 tests pass but the py3 tests fail: [[[ E/usr/lib/python3.5/unittest/case.py:629: ResourceWarning: unclosed file <_io.BufferedWriter name='/tmp/tmpt0y_m2lx'> outcome.errors.clear() E/usr/lib/py