Re: swig-py test failure with textdelta handler

2024-09-28 Thread Yasuhito FUTATSUKI
On 2024/09/26 17:45, Stefan Sperling wrote: > Perhaps the issue is a race condition? In any case, I will let you > decide whether your prefer leaving the test as it is or whether your > new patch improves the test and should be committted. Python library reference for weakref module[1] mentions o

Re: swig-py test failure with textdelta handler

2024-09-26 Thread Stefan Sperling
On Thu, Sep 26, 2024 at 12:18:52PM +0900, Yasuhito FUTATSUKI wrote: > On 2024/09/26 10:59, Yasuhito FUTATSUKI wrote: > > On 2024/09/26 7:43, Yasuhito FUTATSUKI wrote: > >> On 2024/09/26 6:43, Yasuhito FUTATSUKI wrote: > >>> However, if weakref for 'handler' object might still remain after > >>> the

Re: swig-py test failure with textdelta handler

2024-09-25 Thread Yasuhito FUTATSUKI
On 2024/09/26 10:59, Yasuhito FUTATSUKI wrote: > On 2024/09/26 7:43, Yasuhito FUTATSUKI wrote: >> On 2024/09/26 6:43, Yasuhito FUTATSUKI wrote: >>> However, if weakref for 'handler' object might still remain after >>> the last strong reference is cleared, this test is incomplete and >>> it should r

Re: swig-py test failure with textdelta handler

2024-09-25 Thread Yasuhito FUTATSUKI
On 2024/09/26 7:43, Yasuhito FUTATSUKI wrote: > On 2024/09/26 6:43, Yasuhito FUTATSUKI wrote: >> However, if weakref for 'handler' object might still remain after >> the last strong reference is cleared, this test is incomplete and >> it should rewrite to a test based on sys.getrefcount(). > > Or

Re: swig-py test failure with textdelta handler

2024-09-25 Thread Yasuhito FUTATSUKI
On 2024/09/26 6:43, Yasuhito FUTATSUKI wrote: > However, if weakref for 'handler' object might still remain after > the last strong reference is cleared, this test is incomplete and > it should rewrite to a test based on sys.getrefcount(). Or ensure that weakref is cleared by gc. How about with t

Re: swig-py test failure with textdelta handler

2024-09-25 Thread Yasuhito FUTATSUKI
Hello, On 2024/09/26 4:40, Stefan Sperling wrote: > When running swig-py regression tests on the 1.14.x branch, > I see the following failure: > > ...s..F

Re: swig-py test failure with textdelta handler

2024-09-25 Thread Jun Omae
I just confirmed swig-py tests pass with Python 3.7-3.12, 2.7. It is unable to reproduce it. https://github.com/jun66j5/subversion-build/actions/runs/11040634538 Please let me know versions of the dependencies on your environment. Jun Omae (大前 潤) On Thu, Sep 26, 2024 at 4:41 Stefan Sperling

swig-py test failure with textdelta handler

2024-09-25 Thread Stefan Sperling
When running swig-py regression tests on the 1.14.x branch, I see the following failure: ...s..F.