Re: svn_wc_translated_file3

2010-08-12 Thread Julian Foad
it. > > > > In the potential scenario where a user has opted for no pristines or > > compressed pristines, how would TortoiseSVN maintain its current > > functionality without waiting on decompression or network roundtrips? > > I think users will understand

Re: svn_wc_translated_file3

2010-08-09 Thread Greg Stein
On Mon, Aug 9, 2010 at 13:54, Hyrum K. Wright wrote: > On Mon, Aug 9, 2010 at 12:11 PM, Hyrum K. Wright > wrote: >> On Mon, Aug 9, 2010 at 11:51 AM, Stefan Küng wrote: >... >>> * new API svn_wc_translated_file3(): >>>  svn_client_translated_file(const char ** r

Re: svn_wc_translated_file3

2010-08-09 Thread Hyrum K. Wright
is that the location and >>> encoding of pristine contents should be transparent to anybody above >>> libsvn_wc.  While making libsvn_wc much easier to maintain and extend, >>> going that route apparently decreases performance for clients such as >>> Tortois

Re: svn_wc_translated_file3

2010-08-09 Thread Stefan Küng
;t return a file but a file stream. File streams can only be used by svn clients directly, they can't be passed on to external applications so their use is limited. * new API svn_wc_translated_file3(): svn_client_translated_file(const char ** resultfile, svn_boolean_t * copyCreated,

Re: svn_wc_translated_file3

2010-08-09 Thread Hyrum K. Wright
uts they were exploiting. >>  We need to decide if exposing these shortcuts (and adding the >> associated code complexity) is worth it. >> >> In the potential scenario where a user has opted for no pristines or >> compressed pristines, how would TortoiseSVN maintain its curr

Re: svn_wc_translated_file3

2010-08-09 Thread Stefan Küng
can't be passed on to external applications so their use is limited. * new API svn_wc_translated_file3(): svn_client_translated_file(const char ** resultfile, svn_boolean_t * copyCreated, const char * wcfile, svn_boolean_t deleteOnPoolCleanup,

Re: svn_wc_translated_file3

2010-08-09 Thread Hyrum K. Wright
On Mon, Aug 9, 2010 at 7:46 AM, Julian Foad wrote: > On Mon, 2010-08-09, Julian Foad wrote: >> On Mon, 2010-08-09, Bert Huijben wrote: >> > Stefan Küng wrote: >> > > This leads me to another request: would it be possible to 'un-deprecate' >> > > the svn_wc_get_pristine_copy_path() API? >> >> > One

RE: svn_wc_translated_file3

2010-08-09 Thread Julian Foad
On Mon, 2010-08-09, Julian Foad wrote: > On Mon, 2010-08-09, Bert Huijben wrote: > > Stefan Küng wrote: > > > This leads me to another request: would it be possible to 'un-deprecate' > > > the svn_wc_get_pristine_copy_path() API? > > > One of the ideas of WC-NG (which will most likely not be part

RE: svn_wc_translated_file3

2010-08-09 Thread Julian Foad
On Mon, 2010-08-09, Bert Huijben wrote: > Stefan Küng wrote: > > This leads me to another request: would it be possible to 'un-deprecate' > > the svn_wc_get_pristine_copy_path() API? > One of the ideas of WC-NG (which will most likely not be part of 1.7, but > can be added later without really upd

RE: svn_wc_translated_file3

2010-08-09 Thread Bert Huijben
> -Original Message- > From: Stefan Küng [mailto:tortoise...@gmail.com] > Sent: zaterdag 7 augustus 2010 13:07 > To: Daniel Shahaf > Cc: Subversion Development > Subject: Re: svn_wc_translated_file3 > > On 07.08.2010 12:52, Daniel Shahaf wrote: > > What&

Re: svn_wc_translated_file3

2010-08-09 Thread Julian Foad
27;t deprecate it without providing a better replacement. So thanks for sharing this requirement. I think we should *either* restore/un-deprecate svn_wc_get_pristine_copy_path() svn_wc_translated_file3() *or* define APIs that are similar to these except having some proper way to guarantee the lif

Re: svn_wc_translated_file3

2010-08-07 Thread Stefan Küng
On 07.08.2010 12:52, Daniel Shahaf wrote: What's the solution? I'm using svn_wc_get_pristine_copy_path() and disable the deprecated warnings for that API call. I won't get a translated file that way, but most if not all UI diff tools have options to ignore EOLs. And if keywords aren't expand

Re: svn_wc_translated_file3

2010-08-07 Thread Daniel Shahaf
What's the solution? Stefan Küng wrote on Fri, Aug 06, 2010 at 23:56:37 +0200: > Never mind - I found a solution to the problem. > > Stefan > > On Fri, Aug 6, 2010 at 21:42, Stefan Küng wrote: > > Hi, > > > > Just noticed that the API svn_wc_translated_f

Re: svn_wc_translated_file3

2010-08-06 Thread Stefan Küng
Never mind - I found a solution to the problem. Stefan On Fri, Aug 6, 2010 at 21:42, Stefan Küng wrote: > Hi, > > Just noticed that the API svn_wc_translated_file3() has been removed in > r963632: > > Message: > Remove the public libsvn_wc file and stream translation APIs (

svn_wc_translated_file3

2010-08-06 Thread Stefan Küng
Hi, Just noticed that the API svn_wc_translated_file3() has been removed in r963632: Message: Remove the public libsvn_wc file and stream translation APIs (while leaving their deprecated predecessors). These APIs are not consumed by the client. See: http://svn.haxx.se/dev/archive-2010-07