1.8.x@HEAD plus the r1467440,r1467450,r1467481 group in STATUS behaves
as follows in maintainer mode:
% $svnadmin upgrade /
subversion/svnadmin/svnadmin.c:1925,
subversion/libsvn_repos/repos.c:1555,
subversion/libsvn_repos/repos.c:1461,
subversion/libsvn_repos/repos.c:1423,
subversion/libsvn_subr/
Stefan Sperling wrote on Sat, Apr 13, 2013 at 10:39:50 +0200:
> On Sat, Apr 13, 2013 at 03:23:32AM +0300, Daniel Shahaf wrote:
> > % $svnadmin create /
> > svnadmin: E200011: Repository creation failed
> > svnadmin: E200011: Could not create top-level directory
> > svnadmin: E200011: '/' exists and
@@ -589,9 +588,21 @@ svn_handle_error2(svn_error_t *err,
APR_ARRAY_PUSH(empties, apr_status_t) = tmp_err->apr_err;
}
}
+}
- tmp_err = tmp_err->child;
-}
+ for (tmp_err = err; tmp_err; tmp_err = tmp_err->child)
+if (! (tmp_err->child && tmp_err-&g
+1
Bert From: Ivan Zhakov
Sent: 13-4-2013 10:44
To: Daniel Shahaf; dev@subversion.apache.org; C. Michael Pilato; Julian
Foad
Subject: Re: Printing error stacks. (was: Re: svn_error_symbolic_name)
On Sat, Apr 13, 2013 at 12:39 PM, Stefan Sperling wrote:
> On Sat, Apr 13, 2013 at 03:23:32AM +0
On Sat, Apr 13, 2013 at 12:39 PM, Stefan Sperling wrote:
> On Sat, Apr 13, 2013 at 03:23:32AM +0300, Daniel Shahaf wrote:
>> % $svnadmin create /
>> svnadmin: E200011: Repository creation failed
>> svnadmin: E200011: Could not create top-level directory
>> svnadmin: E200011: '/' exists and is non-
On Sat, Apr 13, 2013 at 03:23:32AM +0300, Daniel Shahaf wrote:
> % $svnadmin create /
> svnadmin: E200011: Repository creation failed
> svnadmin: E200011: Could not create top-level directory
> svnadmin: E200011: '/' exists and is non-empty
> (E200011 = DIR_NOT_EMPTY)
> %
>
> Daniel
I like it. C
tmp_err = tmp_err->child;
-}
+ for (tmp_err = err; tmp_err; tmp_err = tmp_err->child)
+if (! (tmp_err->child && tmp_err->apr_err == tmp_err->child->apr_err))
+ {
+const char *symbolic_name = svn_error_symbolic_name(tmp_err->apr_err);
+
On Fri, Apr 12, 2013 at 02:34:26PM -0400, C. Michael Pilato wrote:
> svn: E180003: Unable to connect to a repository at URL
> 'file:///home/cmpilato/tests/arch'
> svn: E180012: Unable to open an ra_local session to URL
> svn: E180001: Unable to open repository 'file:///home/cmpilato/tests/arch'
> (
On Fri, Apr 12, 2013 at 8:27 PM, Daniel Shahaf wrote:
> Prompted by Julian's review of this freshly-minted public API on IRC:
>
> 1. Question to API consumers (eg, client developers): would you find
> this API useful? For reference, the current docstring is attached.
>
I think it *may be* useful
On Fri, Apr 12, 2013 at 11:53 AM, Daniel Shahaf wrote:
> Another idea: avoid printing the (apr_err=) part if it's the same code as the
> line above it (which should be the common case):
>
> subversion/svn/checkout-cmd.c:168 (apr_err=SVN_ERR_RA_LOCAL_REPOS_OPEN_FAILED)
> subversion/libsvn_client/ch
On Fri, Apr 12, 2013 at 02:34:26PM -0400, C. Michael Pilato wrote:
> Daniel, I find the current error display really ... weighty, for lack of a
> better term. It's difficult to pick out the meat of the message amongst the
> overwhelming amount of repetitive, all-caps symbolic names of error codes.
Daniel, I find the current error display really ... weighty, for lack of a
better term. It's difficult to pick out the meat of the message amongst the
overwhelming amount of repetitive, all-caps symbolic names of error codes.
Something to consider: omit the symbolic name from the printed error l
Daniel Shahaf wrote:
> Prompted by Julian's review of this freshly-minted public API on IRC:
>
> 1. Question to API consumers (eg, client developers): would you find
> this API useful? For reference, the current docstring is attached.
>
> 2. Should we print the symbolic name in release builds?
On 04/12/2013 12:27 PM, Daniel Shahaf wrote:
> Prompted by Julian's review of this freshly-minted public API on IRC:
>
> 1. Question to API consumers (eg, client developers): would you find
> this API useful? For reference, the current docstring is attached.
N/A
> 2. Should we print the symboli
more than one symbolic name.
* (For example, #SVN_ERR_WC_NOT_DIRECTORY and #SVN_ERR_WC_NOT_WORKING_COPY).
* In those cases, it is not guaranteed which symbolic name is returned.
*
* @since New in 1.8.
*/
const char *
svn_error_
15 matches
Mail list logo
