Re: svn_client_status5() and depth

2010-08-19 Thread C. Michael Pilato
On 08/19/2010 09:15 AM, Stefan Küng wrote: > What's the harm in leaving the behavior in the old APIs even though it's > not what you intended? Please read the docs for the API again - that > intention isn't documented so the old API works as documented. As someone who was close to the project when

Re: svn_client_status5() and depth

2010-08-19 Thread Stefan Küng
On 18.08.2010 21:58, Bert Huijben wrote: I've checked r986510 and I like to add some comments: In libsvn_client/deprecated.c, svn_client_status4() you pass FALSE for the new sticky param. But that's wrong: in 1.6.x and previous versions, the depth was always respected/enforced. That's why I noti

RE: svn_client_status5() and depth

2010-08-18 Thread Bert Huijben
> -Original Message- > From: Stefan Küng [mailto:tortoise...@gmail.com] > Sent: woensdag 18 augustus 2010 13:37 > To: Bert Huijben > Cc: 'Hyrum K. Wright'; 'C. Michael Pilato'; 'Subversion Development' > Subject: Re: svn_client_status5() an

Re: svn_client_status5() and depth

2010-08-18 Thread Stefan Küng
On 18.08.2010 21:58, Bert Huijben wrote: In libsvn_client/deprecated.c, svn_client_status4() you pass FALSE for the new sticky param. But that's wrong: in 1.6.x and previous versions, the depth was always respected/enforced. That's why I noticed the changed behavior in the first place! Shouldn't

Re: svn_client_status5() and depth

2010-08-18 Thread Hyrum K. Wright
On Wed, Aug 18, 2010 at 7:39 PM, Stefan Küng wrote: > On 17.08.2010 23:41, Hyrum K. Wright wrote: >> >> On Tue, Aug 17, 2010 at 3:45 PM, C. Michael Pilato >>  wrote: >>> >>> On 08/17/2010 01:42 PM, Stefan Küng wrote: Maybe I don't understand that change: --depth specifies a depth to

RE: svn_client_status5() and depth

2010-08-18 Thread Bert Huijben
> -Original Message- > From: Stefan Küng [mailto:tortoise...@gmail.com] > Sent: woensdag 18 augustus 2010 11:39 > To: Hyrum K. Wright > Cc: C. Michael Pilato; Bert Huijben; Subversion Development > Subject: Re: svn_client_status5() and depth > > On 17.08.201

Re: svn_client_status5() and depth

2010-08-18 Thread Stefan Küng
On 17.08.2010 23:41, Hyrum K. Wright wrote: On Tue, Aug 17, 2010 at 3:45 PM, C. Michael Pilato wrote: On 08/17/2010 01:42 PM, Stefan Küng wrote: Maybe I don't understand that change: --depth specifies a depth to use for the command. If I want the command to use the depth of the working copy, I

Re: svn_client_status5() and depth

2010-08-17 Thread Hyrum K. Wright
On Tue, Aug 17, 2010 at 3:45 PM, C. Michael Pilato wrote: > On 08/17/2010 01:42 PM, Stefan Küng wrote: >> Maybe I don't understand that change: >> --depth specifies a depth to use for the command. If I want the command >> to use the depth of the working copy, I specify an unknown depth or none >>

Re: svn_client_status5() and depth

2010-08-17 Thread Stefan Küng
On 17.08.2010 22:45, C. Michael Pilato wrote: On 08/17/2010 01:42 PM, Stefan Küng wrote: Maybe I don't understand that change: --depth specifies a depth to use for the command. If I want the command to use the depth of the working copy, I specify an unknown depth or none at all. But if I specify

Re: svn_client_status5() and depth

2010-08-17 Thread Stefan Küng
On 17.08.2010 22:29, Bert Huijben wrote: But 'svn status' with a --set-depth would mean that this call could change the WC? Until now, 'svn st' didn't change the WC at all, i.e., it was a read-only operation. So is such a change really wanted or necessary? No it doesn't change the WC, but it s

Re: svn_client_status5() and depth

2010-08-17 Thread C. Michael Pilato
On 08/17/2010 01:42 PM, Stefan Küng wrote: > Maybe I don't understand that change: > --depth specifies a depth to use for the command. If I want the command > to use the depth of the working copy, I specify an unknown depth or none > at all. But if I specify a depth, I would assume the command to r

Re: svn_client_status5() and depth

2010-08-17 Thread Stefan Küng
On 17.08.2010 22:32, C. Michael Pilato wrote: On 08/17/2010 12:44 PM, Stefan Küng wrote: Like I said in r957917, I think we should fix this in a different way. The difference is between: What would you get with * svn up --depth infinity and * svn up --set-depth infinity svn status --depth infi

Re: svn_client_status5() and depth

2010-08-17 Thread C. Michael Pilato
On 08/17/2010 12:44 PM, Stefan Küng wrote: >> Like I said in r957917, I think we should fix this in a different way. >> >> The difference is between: >> What would you get with >> * svn up --depth infinity >> and >> * svn up --set-depth infinity >> >> svn status --depth infinity used to show the la

RE: svn_client_status5() and depth

2010-08-17 Thread Bert Huijben
> -Original Message- > From: Stefan Küng [mailto:tortoise...@gmail.com] > Sent: dinsdag 17 augustus 2010 12:45 > To: Bert Huijben > Cc: 'Subversion Development' > Subject: Re: svn_client_status5() and depth > > On 17.08.2010 21:37, Bert Huijben wrote:

Re: svn_client_status5() and depth

2010-08-17 Thread Stefan Küng
On 17.08.2010 21:37, Bert Huijben wrote: -Original Message- From: Stefan Küng [mailto:tortoise...@gmail.com] Sent: dinsdag 17 augustus 2010 12:28 To: Subversion Development Subject: svn_client_status5() and depth Hi, * check out a folder with depth svn_depth_empty (svn co file:///d

RE: svn_client_status5() and depth

2010-08-17 Thread Bert Huijben
> -Original Message- > From: Stefan Küng [mailto:tortoise...@gmail.com] > Sent: dinsdag 17 augustus 2010 12:28 > To: Subversion Development > Subject: svn_client_status5() and depth > > Hi, > > * check out a folder with depth svn_depth_empty (svn co > fi

RE: svn_client_status5() and depth

2010-08-17 Thread Bert Huijben
> -Original Message- > From: Stefan Küng [mailto:tortoise...@gmail.com] > Sent: dinsdag 17 augustus 2010 12:28 > To: Subversion Development > Subject: svn_client_status5() and depth > > Hi, > > * check out a folder with depth svn_depth_empty (svn co > fi

svn_client_status5() and depth

2010-08-17 Thread Stefan Küng
Hi, * check out a folder with depth svn_depth_empty (svn co file:///d:/testrepo/trunk testwc) * cd into that folder (cd testwc) * run 'svn st -u -v --depth infinity' In 1.6.x, I get the status for all the files under that folder that exist in the repository. With the latest trunk (r986453),