Re: svn_client_delete4 can segfault

2011-12-08 Thread Philip Martin
Stefan Küng writes: > from a few crash reports sent in for TSVN I was finally able to pin > down the problem: > > in libsvn_client\delete.c, line 240 there's a call > repos_relpath = svn_uri__is_child(repos_root, uri, pool); > > but that can return NULL. > further below then that repos_relpath is

Re: svn_client_delete4 can segfault

2011-12-07 Thread Julian Foad
Stefan Küng wrote: > on trunk, svn_uri__is_child() has been replaced with svn_uri_skip_ancestor() > (r1198802), but it works the same as svn_uri__is_child() from what I can see. Just answering this bit: no, _skip_ancestor() intentionally returns "" if the child is equal to the parent, whereas _i

svn_client_delete4 can segfault

2011-12-07 Thread Stefan Küng
Hi, from a few crash reports sent in for TSVN I was finally able to pin down the problem: in libsvn_client\delete.c, line 240 there's a call repos_relpath = svn_uri__is_child(repos_root, uri, pool); but that can return NULL. further below then that repos_relpath is passed to svn_ra_check_path