Re: svn commit: r958671 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2010-06-28 Thread Greg Stein
On Mon, Jun 28, 2010 at 15:24, Daniel Shahaf wrote: >... >> > (on s.c.n viewvc's diffs used to ignore whitespace... doesn't seem to be >> > the case on s.a.o though) >> >> Whitespace can be important (e.g Python scripts), so keeping simple >> whitespace changes in the commit email is a Good Thing.

Re: svn commit: r958671 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2010-06-28 Thread Daniel Shahaf
Greg Stein wrote on Mon, 28 Jun 2010 at 22:16 -: > On Mon, Jun 28, 2010 at 14:59, Daniel Shahaf wrote: > > Greg Stein wrote on Mon, 28 Jun 2010 at 21:50 -: > >> How am I supposed to review this? I can't tell what is indentation, > >> versus actual code change. > >> > > > > svn diff -x-w ?

Re: svn commit: r958671 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2010-06-28 Thread Greg Stein
On Mon, Jun 28, 2010 at 14:59, Daniel Shahaf wrote: > Greg Stein wrote on Mon, 28 Jun 2010 at 21:50 -: >> On Mon, Jun 28, 2010 at 14:33,   wrote: >> > Author: rhuijben >> > Date: Mon Jun 28 18:33:05 2010 >> > New Revision: 958671 >> > >> > URL: http://svn.apache.org/viewvc?rev=958671&view=rev

Re: svn commit: r958671 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2010-06-28 Thread Daniel Shahaf
Greg Stein wrote on Mon, 28 Jun 2010 at 21:50 -: > On Mon, Jun 28, 2010 at 14:33, wrote: > > Author: rhuijben > > Date: Mon Jun 28 18:33:05 2010 > > New Revision: 958671 > > > > URL: http://svn.apache.org/viewvc?rev=958671&view=rev > > Log: > > * subversion/libsvn_wc/adm_ops.c > >  (svn_wc_ad

Re: svn commit: r958671 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2010-06-28 Thread Greg Stein
On Mon, Jun 28, 2010 at 14:33, wrote: > Author: rhuijben > Date: Mon Jun 28 18:33:05 2010 > New Revision: 958671 > > URL: http://svn.apache.org/viewvc?rev=958671&view=rev > Log: > * subversion/libsvn_wc/adm_ops.c >  (svn_wc_add4): Fix indentation and remove a few more unneeded ifs. Argh!!! How