Re: svn commit: r934008 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2010-04-14 Thread Philip Martin
Daniel Shahaf writes: > phi...@apache.org wrote on Wed, 14 Apr 2010 at 16:35 -: >> - /* We could use the SQLite backup interface (from 3.6.11 and still >> - experimental) and the copy would be done in chunks with the lock >> - released between chunks. */ >> +#if SQLITE_VERSION_AT_LEA

Re: svn commit: r934008 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2010-04-14 Thread Daniel Shahaf
phi...@apache.org wrote on Wed, 14 Apr 2010 at 16:35 -: > - /* We could use the SQLite backup interface (from 3.6.11 and still > - experimental) and the copy would be done in chunks with the lock > - released between chunks. */ > +#if SQLITE_VERSION_AT_LEAST(3,6,11) > + { Given that

Re: svn commit: r934008 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2010-04-14 Thread Philip Martin
Greg Stein writes: >> +    SVN_ERR(svn_sqlite__open(&dst_db, dst_path, svn_sqlite__mode_rwcreate, >> +                             NULL, 0, NULL, scratch_pool, scratch_pool)); >> +    backup = sqlite3_backup_init(dst_db->db3, "main", src_db->db3, "main"); >> +    if (!backup) >> +      return SVN

Re: svn commit: r934008 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2010-04-14 Thread Greg Stein
On Wed, Apr 14, 2010 at 12:35, wrote: >... > +++ subversion/trunk/subversion/libsvn_subr/sqlite.c Wed Apr 14 16:35:11 2010 > @@ -975,23 +975,55 @@ svn_sqlite__hotcopy(const char *src_path >                     const char *dst_path, >                     apr_pool_t *scratch_pool) >  { > -  svn_sql

Re: svn commit: r934008 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2010-04-14 Thread C. Michael Pilato
Philip Martin wrote: > phi...@apache.org writes: > >> Author: philip >> Date: Wed Apr 14 16:35:11 2010 >> New Revision: 934008 >> >> URL: http://svn.apache.org/viewvc?rev=934008&view=rev >> Log: >> * subversion/libsvn_subr/sqlite.c >> (svn_sqlite__hotcopy): Use the SQLite backup interface if ava

Re: svn commit: r934008 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2010-04-14 Thread Greg Stein
On Wed, Apr 14, 2010 at 12:43, Philip Martin wrote: > phi...@apache.org writes: > >> Author: philip >> Date: Wed Apr 14 16:35:11 2010 >> New Revision: 934008 >> >> URL: http://svn.apache.org/viewvc?rev=934008&view=rev >> Log: >> * subversion/libsvn_subr/sqlite.c >>   (svn_sqlite__hotcopy): Use the

Re: svn commit: r934008 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2010-04-14 Thread Philip Martin
phi...@apache.org writes: > Author: philip > Date: Wed Apr 14 16:35:11 2010 > New Revision: 934008 > > URL: http://svn.apache.org/viewvc?rev=934008&view=rev > Log: > * subversion/libsvn_subr/sqlite.c > (svn_sqlite__hotcopy): Use the SQLite backup interface if available. > > Modified: > subve