Re: svn commit: r911804 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2010-02-23 Thread Hyrum K. Wright
It should be noted that as of 1.6 we've been using SHA1 hashes to index content on the server (which obviously includes all nodes on the client), and we've yet to hear any reports of checksum collisions. I do not doubt that it is theoretically possible, but in practice, the threat of SHA1 colli

Re: svn commit: r911804 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2010-02-23 Thread Ed Price
For those of us who use Subversion to manage our home directories, or other random collections of files, it's entirely possible and reasonable that we might download some files with identical checksums, just out of curiosity or whatever. I do think it would be a shame if Subversion caused or suffe

Re: svn commit: r911804 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2010-02-22 Thread Julian Foad
Greg Stein wrote: > On Fri, Feb 19, 2010 at 08:13, wrote: > >... > > +++ subversion/trunk/subversion/libsvn_wc/wc-metadata.sql Fri Feb 19 > > 13:13:09 2010 > > @@ -172,7 +172,9 @@ > >and ACTUAL_NODE tables. > > */ > > CREATE TABLE PRISTINE ( > > - /* ### the hash algorithm (MD5 or SHA-1)

Re: svn commit: r911804 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2010-02-19 Thread Stefan Sperling
On Fri, Feb 19, 2010 at 11:11:57AM -0500, Greg Stein wrote: > On Fri, Feb 19, 2010 at 08:13, wrote: > >   /* Alternative MD5 checksum used for communicating with older > > -     repositories. */ > > +     repositories. Not guaranteed to be unique among table rows. > > pfft. riight. Just wai

Re: svn commit: r911804 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2010-02-19 Thread Greg Stein
On Fri, Feb 19, 2010 at 08:13, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/wc-metadata.sql Fri Feb 19 13:13:09 > 2010 > @@ -172,7 +172,9 @@ >    and ACTUAL_NODE tables. >  */ >  CREATE TABLE PRISTINE ( > -  /* ### the hash algorithm (MD5 or SHA-1) is encoded in this value */ > +  /*