Re: svn commit: r903342 - /subversion/trunk/subversion/libsvn_diff/parse-diff.c

2010-01-26 Thread Stefan Sperling
On Tue, Jan 26, 2010 at 11:23:18AM -0800, Blair Zajac wrote: > On 01/26/2010 10:32 AM, Stefan Sperling wrote: > >I've been told some time ago, by long-time unix hackers, > >that clearning errno is usually not necessary, one of the few > >exceptions to this rule being the strtol() family of function

Re: svn commit: r903342 - /subversion/trunk/subversion/libsvn_diff/parse-diff.c

2010-01-26 Thread Blair Zajac
On 01/26/2010 10:32 AM, Stefan Sperling wrote: On Tue, Jan 26, 2010 at 10:02:02AM -0800, Blair Zajac wrote: On 01/26/2010 09:54 AM, s...@apache.org wrote: Author: stsp Date: Tue Jan 26 17:54:14 2010 New Revision: 903342 URL: http://svn.apache.org/viewvc?rev=903342&view=rev Log: * subversion/li

Re: svn commit: r903342 - /subversion/trunk/subversion/libsvn_diff/parse-diff.c

2010-01-26 Thread Stefan Sperling
On Tue, Jan 26, 2010 at 10:02:02AM -0800, Blair Zajac wrote: > On 01/26/2010 09:54 AM, s...@apache.org wrote: > >Author: stsp > >Date: Tue Jan 26 17:54:14 2010 > >New Revision: 903342 > > > >URL: http://svn.apache.org/viewvc?rev=903342&view=rev > >Log: > >* subversion/libsvn_diff/parse-diff.c > >

Re: svn commit: r903342 - /subversion/trunk/subversion/libsvn_diff/parse-diff.c

2010-01-26 Thread Blair Zajac
On 01/26/2010 09:54 AM, s...@apache.org wrote: Author: stsp Date: Tue Jan 26 17:54:14 2010 New Revision: 903342 URL: http://svn.apache.org/viewvc?rev=903342&view=rev Log: * subversion/libsvn_diff/parse-diff.c (parse_offset): Clearing errno is never necessary, so don't. Why are you claiming