Re: svn commit: r1869118 - /subversion/trunk/tools/dist/release.py

2019-10-30 Thread Julian Foad
Daniel Shahaf wrote: Julian Foad wrote on Tue, 29 Oct 2019 20:54 +00:00: At a quick try I couldn't get either "time.strptime" nor "datetime.strptime" to work. The latter says "AttributeError: [...] Thanks, r1869134. The AttributeError was likely because the function's fully-qualified name is

Re: svn commit: r1869118 - /subversion/trunk/tools/dist/release.py

2019-10-29 Thread Daniel Shahaf
Julian Foad wrote on Tue, 29 Oct 2019 20:54 +00:00: > Daniel Shahaf wrote: > > release_date = time.strptime(args.news_release_date, "-mm-dd") if > > args.news_release_date else datetime.date.today() > > … { 'date': release_date.strftime("mmdd"), > > 'date_pres': release_date.strftime(

Re: svn commit: r1869118 - /subversion/trunk/tools/dist/release.py

2019-10-29 Thread Julian Foad
Daniel Shahaf wrote: You don't do any input validation on the date in argv anywhere, so Right. I'm not wanting to spend much time on niceties as I want to change a lot of this to read data from somewhere else, but then it still might want validating at this level. [...] release_date = tim

Re: svn commit: r1869118 - /subversion/trunk/tools/dist/release.py

2019-10-29 Thread Daniel Shahaf
julianf...@apache.org wrote on Tue, 29 Oct 2019 17:22 +00:00: > +++ subversion/trunk/tools/dist/release.py Tue Oct 29 17:22:40 2019 > @@ -1188,8 +1188,9 @@ def move_to_dist(args): > def write_news(args): > 'Write text for the Subversion website.' > -data = { 'date' : datetime.date.today()