Re: svn commit: r1683126 - /subversion/trunk/subversion/libsvn_fs_x/cached_data.c

2015-06-03 Thread Philip Martin
Ivan Zhakov writes: > FWIW libsvn_fsfs uses dirent->name as key since it's already copied to > result_pool: That was a FSFS change in r1572049; I think it is a better solution so I have applied it to FSX. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1683126 - /subversion/trunk/subversion/libsvn_fs_x/cached_data.c

2015-06-03 Thread Ivan Zhakov
On 3 June 2015 at 12:39, Philip Martin wrote: > Bert Huijben writes: > >> Strange… this should never be necessarily when *removing* something >> from a hash (value =NULL). >> >> >> I think you see some kind of other problem. > > I agree this bit is unnecessary, I have changed it back. > >> @@ -24

Re: svn commit: r1683126 - /subversion/trunk/subversion/libsvn_fs_x/cached_data.c

2015-06-03 Thread Philip Martin
Bert Huijben writes: > Strange… this should never be necessarily when *removing* something > from a hash (value =NULL). > > > I think you see some kind of other problem. I agree this bit is unnecessary, I have changed it back. > @@ -2494,7 +2494,9 @@ read_dir_entries(apr_array_header_t *ent >

Re: svn commit: r1683126 - /subversion/trunk/subversion/libsvn_fs_x/cached_data.c

2015-06-02 Thread Branko Čibej
On 02.06.2015 18:30, Bert Huijben wrote: > Strange… this should never be necessarily when *removing* something > from a hash (value =NULL). > > I think you see some kind of other problem. > > Bert > > Sent from Surface > > *From:* Philip Martin > *Sent:* ‎Tuesday‎, ‎June‎

Re: svn commit: r1683126 - /subversion/trunk/subversion/libsvn_fs_x/cached_data.c

2015-06-02 Thread Bert Huijben
Strange… this should never be necessarily when *removing* something from a hash (value =NULL). I think you see some kind of other problem. Bert Sent from Surface From: Philip Martin Sent: ‎Tuesday‎, ‎June‎ ‎2‎, ‎2015 ‎5‎:‎19‎ ‎PM To: comm...@subversion.apache.org Author: philip