Re: svn commit: r1663780 - /subversion/trunk/subversion/include/svn_hash.h

2015-03-04 Thread Julian Foad
All resolved via IRC now. See r1663940. - Julian I (Julian Foad) wrote: > Branko and Bert, I'm still not sure I understand what is needed for the > Windows build. [...] > Now I don't know which is correct (#ifdef or not) and I understand I do need > to add svn_hash__[gs]ets to a list of expor

Re: svn commit: r1663780 - /subversion/trunk/subversion/include/svn_hash.h

2015-03-04 Thread Julian Foad
Branko and Bert, I'm still not sure I understand what is needed for the Windows build. >>> -#ifdef SVN_DEBUG >>>  /* In debug builds, the svn_hash_gets macro forwards the parameters >>>  * through this function in order to have parameter type checking, >>>  * particularly for the key. The svn_h

Re: svn commit: r1663780 - /subversion/trunk/subversion/include/svn_hash.h

2015-03-04 Thread Branko Čibej
On 04.03.2015 09:37, Bert Huijben wrote: > As noted on irc we have one .def file that is used for release and > maintenance builds. This generated file has all the function names > that are published by a .DLL. > > If the function is not in the list, we can’t use it in maintainer > builds from libr

Re: svn commit: r1663780 - /subversion/trunk/subversion/include/svn_hash.h

2015-03-04 Thread Bert Huijben
As noted on irc we have one .def file that is used for release and maintenance builds. This generated file has all the function names that are published by a .DLL. If the function is not in the list, we can’t use it in maintainer builds from libraries != libsvn_subr. And if it is in the list,

Re: svn commit: r1663780 - /subversion/trunk/subversion/include/svn_hash.h

2015-03-04 Thread Branko Čibej
On 03.03.2015 21:28, julianf...@apache.org wrote: > Author: julianfoad > Date: Tue Mar 3 20:28:30 2015 > New Revision: 1663780 > > URL: http://svn.apache.org/r1663780 > Log: > * subversion/include/svn_hash.h > (svn_hash__gets): Remove #if from prototype to match definition. > > Modified: > s