Re: svn commit: r1648253 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c

2014-12-30 Thread Stefan Fuhrmann
On Tue, Dec 30, 2014 at 5:01 PM, Branko Čibej wrote: > On 30.12.2014 16:35, Ivan Zhakov wrote: > > Just to make things clear. The thorough review was already provided. > > In short, subpools are not a solution for the root cause of the > > problem being discussed. > The last bit is where we disa

Re: svn commit: r1648253 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c

2014-12-30 Thread Branko Čibej
On 30.12.2014 16:35, Ivan Zhakov wrote: > Just to make things clear. The thorough review was already provided. > In short, subpools are not a solution for the root cause of the > problem being discussed. It strikes me that the root problem is amazingly similar to the issue we had with pool lifeti

Re: svn commit: r1648253 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c

2014-12-30 Thread Ivan Zhakov
On 30 December 2014 at 17:29, Stefan Fuhrmann wrote: > n Tue, Dec 30, 2014 at 2:03 PM, Ivan Zhakov wrote: >> >> On 29 December 2014 at 17:39, Stefan Fuhrmann >> wrote: >> > On Mon, Dec 29, 2014 at 1:46 PM, Evgeny Kotkov >> > >> > wrote: >> >> >> >> Stefan Fuhrmann writes: >> >> >> [...] >> >>

Re: svn commit: r1648253 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c

2014-12-30 Thread Stefan Fuhrmann
n Tue, Dec 30, 2014 at 2:03 PM, Ivan Zhakov wrote: > On 29 December 2014 at 17:39, Stefan Fuhrmann > wrote: > > On Mon, Dec 29, 2014 at 1:46 PM, Evgeny Kotkov < > evgeny.kot...@visualsvn.com> > > wrote: > >> > >> Stefan Fuhrmann writes: > >> > [...] > >> > >>libsvn_fs-1.dll!get_node_revisio

Re: svn commit: r1648253 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c

2014-12-30 Thread Ivan Zhakov
On 29 December 2014 at 17:39, Stefan Fuhrmann wrote: > On Mon, Dec 29, 2014 at 1:46 PM, Evgeny Kotkov > wrote: >> >> Stefan Fuhrmann writes: >> [...] >> >>libsvn_fs-1.dll!get_node_revision_body() >>libsvn_fs-1.dll!svn_fs_fs__dag_get_node() >>libsvn_fs-1.dll!open_path() >>libsvn_f

Re: svn commit: r1648253 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c

2014-12-29 Thread Stefan Fuhrmann
On Mon, Dec 29, 2014 at 1:46 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > In FSFS, use sub-pools for temporaries in those API function > implementations > > that call open_path(). > > > > All these functions are complex enough to make the overhead of creating a > > temporary sub-pool

Re: svn commit: r1648253 - /subversion/trunk/subversion/libsvn_fs_fs/tree.c

2014-12-29 Thread Evgeny Kotkov
Stefan Fuhrmann writes: > In FSFS, use sub-pools for temporaries in those API function implementations > that call open_path(). > > All these functions are complex enough to make the overhead of creating a > temporary sub-pool be outweighed by the benefits of tighter memory usage and > better iso