RE: svn commit: r1591301-/subversion/trunk/subversion/libsvn_client/mergeinfo.c

2014-05-01 Thread Bert Huijben
Thanks for the detailed response, Bert -Original Message- From: "Julian Foad" Sent: ‎1-‎5-‎2014 15:12 To: "Bert Huijben" Cc: "dev@subversion.apache.org" Subject: Re: svn commit: r1591301-/subversion/trunk/subversion/libsvn_client/mergeinfo.c Bert Huij

Re: svn commit: r1591301 -/subversion/trunk/subversion/libsvn_client/mergeinfo.c

2014-05-01 Thread Julian Foad
Bert Huijben wrote: > Are you sure that it doesn't return the mergeinfo as it applies to the > target, even if it has found that information by looking at the parent? > (That is what I tried to say) Hi, Bert. Note the comment on the code I changed:   /* Get the TARGET_WCPATH's explicit mergeinfo.

Re: svn commit: r1591301 -/subversion/trunk/subversion/libsvn_client/mergeinfo.c

2014-05-01 Thread Bert Huijben
Are you sure that it doesn't return the mergeinfo as it applies to the target, even if it has found that information by looking at the parent? (That is what I tried to say) I'm not familiar enough with this code to really review it from just the code, but this eliding code is quite sensitive a

Re: svn commit: r1591301 -/subversion/trunk/subversion/libsvn_client/mergeinfo.c

2014-05-01 Thread Julian Foad
Bert Huijben wrote: > This might make us add svn:mergeinfo on nodes that didn't have this property > before eliding, while the old code tried to avoid that by checking to see if > the value was inherited from an ancestor. Hi Bert. I can't quite parse your sentence unambiguously, but I believe this

RE: svn commit: r1591301 -/subversion/trunk/subversion/libsvn_client/mergeinfo.c

2014-04-30 Thread Bert Huijben
16:12 To: "comm...@subversion.apache.org" Subject: svn commit: r1591301 -/subversion/trunk/subversion/libsvn_client/mergeinfo.c Author: julianfoad Date: Wed Apr 30 14:12:08 2014 New Revision: 1591301 URL: http://svn.apache.org/r1591301 Log: * subversion/libsvn_client/mergeinfo.c (sv