Re: svn commit: r1565531 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

2014-08-01 Thread Ben Reser
On 8/1/14 8:23 AM, Ivan Zhakov wrote: > I think it will be more clear to write code in the following way: > [[ > san = svn_hash_gets(serf_cert, "subjectAltName"); > /* Match server certificate CN with the hostname of the server iff >* we didn't find any subjectAltName fields and

Re: svn commit: r1565531 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

2014-08-01 Thread Ivan Zhakov
On 7 February 2014 08:32, wrote: > Author: breser > Date: Fri Feb 7 04:32:50 2014 > New Revision: 1565531 > > URL: http://svn.apache.org/r1565531 > Log: > ra_serf: Do not compare the CommonName of a certificate if there are > subjectAltName extensions of the DNS type when validating the certific

Re: svn commit: r1565531 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

2014-02-17 Thread Julian Foad
Ben fixed this in r1568349. Thanks, Ben. - Julian Julian Foad wrote: > This commit is causing a change of behaviour for me against the Apache svn > repo. [...] >>  +      svn_boolean_t found_san_entry; >> >>  @@ -232,6 +233,7 @@ ssl_server_cert(void *baton, int failure >>         /* Try to fi

Re: svn commit: r1565531 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

2014-02-14 Thread Julian Foad
This commit is causing a change of behaviour for me against the Apache svn repo. I think there is an error in this code. The error I get when trying to run a merge into an svn trunk WC from an svn branch is: $ svn merge --non-interactive ^/subversion/branches/fsfs-ucsnorm/ /home/julianfoad/src/