Re: svn commit: r1547866 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c

2013-12-05 Thread Stefan Sperling
On Thu, Dec 05, 2013 at 02:30:23PM +, Philip Martin wrote: > Create a repository with group write access: > > (umask 002 ; svnadmin create repo) > > -rw-rw-r-- 1 pm pm 2 Dec 5 14:27 repo/db/current > -r--r--r-- 1 pm pm 115 Dec 5 14:27 repo/db/revs/0/0 > > Accidentally commit with umask d

Re: svn commit: r1547866 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c

2013-12-05 Thread Philip Martin
Stefan Sperling writes: > I think we do want umask permissions. The rep-cache is written by > the server process, and there are cases where the group write bit > must be set for this to work (e.g. in some svn+ssh setups). In any > case the server process will have the proper umask configured, so

Re: svn commit: r1547866 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c

2013-12-05 Thread Stefan Sperling
On Wed, Dec 04, 2013 at 08:09:32PM +, Philip Martin wrote: > Philip Martin writes: > > > Stefan Sperling writes: > > > >> Oops, I pasted an old version of my diff. Here's the final one, > >> mostly with adjusted comments. > >> > >> Overall, I like your trick with creating an empty file bette

Re: svn commit: r1547866 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c

2013-12-04 Thread Philip Martin
Philip Martin writes: > Stefan Sperling writes: > >> Oops, I pasted an old version of my diff. Here's the final one, >> mostly with adjusted comments. >> >> Overall, I like your trick with creating an empty file better. >> >> What do you think about making 'svnadmin create' create rep-cache.db?

Re: svn commit: r1547866 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c

2013-12-04 Thread Philip Martin
Stefan Sperling writes: > Oops, I pasted an old version of my diff. Here's the final one, > mostly with adjusted comments. > > Overall, I like your trick with creating an empty file better. > > What do you think about making 'svnadmin create' create rep-cache.db? My new code makes rep-cache.db h

Re: svn commit: r1547866 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c

2013-12-04 Thread Stefan Sperling
On Wed, Dec 04, 2013 at 07:36:57PM +0100, Stefan Sperling wrote: > On Wed, Dec 04, 2013 at 06:16:40PM -, phi...@apache.org wrote: > > Author: philip > > Date: Wed Dec 4 18:16:40 2013 > > New Revision: 1547866 > > > > URL: http://svn.apache.org/r1547866 > > Log: > > Fix issue 3437, rep-cache.d

Re: svn commit: r1547866 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c

2013-12-04 Thread Stefan Sperling
On Wed, Dec 04, 2013 at 06:16:40PM -, phi...@apache.org wrote: > Author: philip > Date: Wed Dec 4 18:16:40 2013 > New Revision: 1547866 > > URL: http://svn.apache.org/r1547866 > Log: > Fix issue 3437, rep-cache.db created with wrong permissions. > > * subversion/libsvn_fs_fs/rep-cache.c >