Re: [PATCH] Re: svn commit: r1476563 - /subversion/trunk/subversion/svnserve/serve.c

2013-04-27 Thread Daniel Shahaf
Julian Foad wrote on Sat, Apr 27, 2013 at 17:51:22 +0100: > Daniel Shahaf > > @@ -197,7 +198,10 @@ svn_ra_svn__skip_leading_garbage(svn_ra_svn_conn_t > >   * contains two elements, an error will result. > >   * > >   * 'B' is similar to 'b', but may be used in the optional tuple > > specification

Re: [PATCH] Re: svn commit: r1476563 - /subversion/trunk/subversion/svnserve/serve.c

2013-04-27 Thread Julian Foad
Daniel Shahaf > Bert Huijben wrote: > Daniel Shahaf wrote on Sat, Apr 27, 2013 at 17:46:42 +0300: >> Bert Huijben wrote on Sat, Apr 27, 2013 at 16:43:29 +0200: >>> (Another option would be to start using our tristate enum for this case... >>> But we made this svnserve<->libsvn_ra_svn api public fo

Re: [PATCH] Re: svn commit: r1476563 - /subversion/trunk/subversion/svnserve/serve.c

2013-04-27 Thread Branko Čibej
On 27.04.2013 17:01, Daniel Shahaf wrote: > Daniel Shahaf wrote on Sat, Apr 27, 2013 at 17:46:42 +0300: >> Bert Huijben wrote on Sat, Apr 27, 2013 at 16:43:29 +0200: >>> (Another option would be to start using our tristate enum for this case... >>> But we made this svnserve<->libsvn_ra_svn api publ

[PATCH] Re: svn commit: r1476563 - /subversion/trunk/subversion/svnserve/serve.c

2013-04-27 Thread Daniel Shahaf
Daniel Shahaf wrote on Sat, Apr 27, 2013 at 17:46:42 +0300: > Bert Huijben wrote on Sat, Apr 27, 2013 at 16:43:29 +0200: > > (Another option would be to start using our tristate enum for this case... > > But we made this svnserve<->libsvn_ra_svn api public following our old > > inter-library rules)

Re: svn commit: r1476563 - /subversion/trunk/subversion/svnserve/serve.c

2013-04-27 Thread Daniel Shahaf
Bert Huijben wrote on Sat, Apr 27, 2013 at 16:43:29 +0200: > (Another option would be to start using our tristate enum for this case... > But we made this svnserve<->libsvn_ra_svn api public following our old > inter-library rules) +1 And svn_ra_svn__parse_number is now a private API, the public

RE: svn commit: r1476563 - /subversion/trunk/subversion/svnserve/serve.c

2013-04-27 Thread Bert Huijben
> -Original Message- > From: Daniel Shahaf [mailto:danie...@elego.de] > Sent: zaterdag 27 april 2013 16:36 > To: dev@subversion.apache.org > Cc: comm...@subversion.apache.org > Subject: Re: svn commit: r1476563 - > /subversion/trunk/subversion/svnserve/serve.c >

Re: svn commit: r1476563 - /subversion/trunk/subversion/svnserve/serve.c

2013-04-27 Thread Daniel Shahaf
That's wrong since 'B' may return SVN_RA_SVN__UNSPECIFIED_NUMBER. In fact, you reverted r1466659 which was a bugfix. br...@apache.org wrote on Sat, Apr 27, 2013 at 12:28:44 -: > Author: brane > Date: Sat Apr 27 12:28:44 2013 > New Revision: 1476563 > > URL: http://svn.apache.org/r1476563 > L

Re: svn commit: r1476563 - /subversion/trunk/subversion/svnserve/serve.c

2013-04-27 Thread Bert Huijben
Some of these tests are now more robust but completely wrong as the value had 3 defined values where one now has exactly the opposite result and usually breaks compatibility when using older clients... The B type has an explicit undefined value for when the value is not sent over the connectio