Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/

2013-02-03 Thread Stefan Sperling
On Sun, Feb 03, 2013 at 07:42:42AM -0500, Justin Erenkrantz wrote: > On Sun, Feb 3, 2013 at 6:42 AM, Stefan Sperling wrote: > > Perhaps we should treat mime-types that contain 'charset=UTF-8' > > as text by default? libmagic is able to detect the charset AFAIK. > > Our code currently removes chars

Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/

2013-02-03 Thread Justin Erenkrantz
On Sun, Feb 3, 2013 at 6:42 AM, Stefan Sperling wrote: > On Sun, Feb 03, 2013 at 06:16:03AM -0500, Justin Erenkrantz wrote: > > On Sun, Feb 3, 2013 at 6:06 AM, Justin Erenkrantz >wrote: > > > > > I thought we treated application/xml as text at one time? -- justin > > > > > > > Yes, we did...and

Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/

2013-02-03 Thread Stefan Sperling
On Sun, Feb 03, 2013 at 06:16:03AM -0500, Justin Erenkrantz wrote: > On Sun, Feb 3, 2013 at 6:06 AM, Justin Erenkrantz > wrote: > > > I thought we treated application/xml as text at one time? -- justin > > > > Yes, we did...and Ben -1'ed it back in 2004. See: > > http://subversion.tigris.org/

Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/ tests/cmdline/

2013-02-03 Thread Stefan Sperling
On Sat, Feb 02, 2013 at 10:49:50PM +, Julian Foad wrote: > Maybe change the wording to be clear that Subversion *considers* this to be a > 'binary' MIME type?  Quite likely it is actually a text type that Subversion > doesn't know about, and then saying "application/foomatic-plain-text is a

Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/ tests/cmdline/

2013-02-03 Thread Stefan Sperling
On Sat, Feb 02, 2013 at 11:38:56PM +0100, Bert Huijben wrote: >From my users I hear that another way this property is introduced is via >conversions from other version management systems. Visual SourceSafe (long >dead, but still used in a lot of small shops) marks UTF-8 files with a BOM as >bina

Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/

2013-02-03 Thread Justin Erenkrantz
On Sun, Feb 3, 2013 at 6:06 AM, Justin Erenkrantz wrote: > I thought we treated application/xml as text at one time? -- justin > Yes, we did...and Ben -1'ed it back in 2004. See: http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=374218 I guess...but...really? Is the on

Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/

2013-02-03 Thread Justin Erenkrantz
On Sun, Feb 3, 2013 at 4:41 AM, Bert Huijben wrote: > Maybe we should try to fix this automatic detection then (Does your > setting match the libmagic output for that file?) instead of adding > just a warning when setting the file binary explicitly. > > Maybe we should validate our libmagic based

RE: svn commit: r1441814 - in /subversion/trunk/subversion: svn/

2013-02-03 Thread Bert Huijben
en Cc: dev@subversion.apache.org Subject: Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/ tests/cmdline/ As another data point, I have hit this text-as-binary myself just a few weeks ago when I added a bunch of HTML files to a local repository - so, it's definitely occurring au

Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/ tests/cmdline/

2013-02-03 Thread Justin Erenkrantz
urday, February 2, 2013, Bert Huijben wrote: > > > > -Original Message- > > From: s...@apache.org [mailto:s...@apache.org > ] > > Sent: zaterdag 2 februari 2013 23:05 > > To: comm...@subversion.apache.org > > Subject: svn commit: r1441814 - in /subvers

Re: svn commit: r1441814 - in /subversion/trunk/subversion: svn/ tests/cmdline/

2013-02-02 Thread Julian Foad
Bert Huijben wrote: >> Author: stsp >> >> URL: http://svn.apache.org/viewvc?rev=1441814&view=rev >> Log: >> When a binary mime-type is set on a file that looks like a text file, >> make the 'svn' client print a warning about potential future problems >> with operations such as diff, merge,

RE: svn commit: r1441814 - in /subversion/trunk/subversion: svn/ tests/cmdline/

2013-02-02 Thread Bert Huijben
> -Original Message- > From: s...@apache.org [mailto:s...@apache.org] > Sent: zaterdag 2 februari 2013 23:05 > To: comm...@subversion.apache.org > Subject: svn commit: r1441814 - in /subversion/trunk/subversion: svn/ > tests/cmdline/ > > Author: stsp > Dat