Re: svn commit: r1369183 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-08-03 Thread Julian Foad
Greg Stein wrote: > Julian Foad wrote: >> snprintf/vsnprintf isn't in C'89. > > There is an APR version of that, I believe. OK, r1369221. - Julian >> Use it anyway, or perhaps clear the pool after using it instead? > > I thought about clearing the pool, but that could crash when threads are

Re: svn commit: r1369183 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-08-03 Thread Greg Stein
On Aug 3, 2012 5:01 PM, "Julian Foad" wrote: > > Greg Stein wrote: > > > On Fri, Aug 3, 2012 at 3:49 PM, wrote: > >> ... > >> * subversion/libsvn_subr/debug.c > >>(debug_pool, debug_file, debug_line): New variables. > >>(svn_dbg__preamble): Create a pool, the first time we're called. Ju

Re: svn commit: r1369183 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-08-03 Thread Julian Foad
Greg Stein wrote: > On Fri, Aug 3, 2012 at 3:49 PM,  wrote: >> ... >> * subversion/libsvn_subr/debug.c >>   (debug_pool, debug_file, debug_line): New variables. >>   (svn_dbg__preamble): Create a pool, the first time we're called. Just >>     store the prefix information instead of printing i

Re: svn commit: r1369183 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-08-03 Thread Greg Stein
On Fri, Aug 3, 2012 at 3:49 PM, wrote: >... > * subversion/libsvn_subr/debug.c > (debug_pool, debug_file, debug_line): New variables. > (svn_dbg__preamble): Create a pool, the first time we're called. Just > store the prefix information instead of printing it. (Note: this isn't > thre