Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-21 Thread Stefan Fuhrmann
On Thu, Oct 18, 2012 at 10:46 PM, Daniel Shahaf wrote: > Stefan Fuhrmann wrote on Thu, Oct 18, 2012 at 02:26:13 +0200: > > On Thu, Oct 18, 2012 at 1:57 AM, Daniel Shahaf >wrote: > > > > > Branko Čibej wrote on Mon, Oct 15, 2012 at 23:51:43 -0400: > > > > On 15.10.2012 17:14, Stefan Fuhrmann wrote

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-18 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Thu, Oct 18, 2012 at 02:26:13 +0200: > No need to go off on a hyperbole. Raise your > concerns in a factual way and hold off meta- > discussion until after those facts got confirmed. > > Still appreciate the review, though. And, yes, the > coded logic may contain holes and

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-18 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Thu, Oct 18, 2012 at 02:26:13 +0200: > On Thu, Oct 18, 2012 at 1:57 AM, Daniel Shahaf wrote: > > > Branko Čibej wrote on Mon, Oct 15, 2012 at 23:51:43 -0400: > > > On 15.10.2012 17:14, Stefan Fuhrmann wrote: > > > > However, if you have a long-running process like a server

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-17 Thread Stefan Fuhrmann
On Thu, Oct 18, 2012 at 1:57 AM, Daniel Shahaf wrote: > Branko Čibej wrote on Mon, Oct 15, 2012 at 23:51:43 -0400: > > On 15.10.2012 17:14, Stefan Fuhrmann wrote: > > > However, if you have a long-running process like a server, that race > > > condition extends now extends over its whole lifetime.

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-17 Thread Daniel Shahaf
Branko Čibej wrote on Mon, Oct 15, 2012 at 23:51:43 -0400: > On 15.10.2012 17:14, Stefan Fuhrmann wrote: > > However, if you have a long-running process like a server, that race > > condition extends now extends over its whole lifetime. I.e. once a > > revprop got read, any change to its value by a

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-16 Thread Johan Corveleyn
On Tue, Oct 16, 2012 at 7:13 AM, Stefan Fuhrmann wrote: > On Tue, Oct 16, 2012 at 5:51 AM, Branko Čibej wrote: >> >> On 15.10.2012 17:14, Stefan Fuhrmann wrote: >> > However, if you have a long-running process like a server, that race >> > condition extends now extends over its whole lifetime. I.

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Stefan Fuhrmann
On Tue, Oct 16, 2012 at 5:51 AM, Branko Čibej wrote: > On 15.10.2012 17:14, Stefan Fuhrmann wrote: > > However, if you have a long-running process like a server, that race > > condition extends now extends over its whole lifetime. I.e. once a > > revprop got read, any change to its value by a pre

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Branko Čibej
On 15.10.2012 17:14, Stefan Fuhrmann wrote: > However, if you have a long-running process like a server, that race > condition extends now extends over its whole lifetime. I.e. once a > revprop got read, any change to its value by a pre-1.8 tool may never > get detected. Ouch. This seems wrong. I'

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Philip Martin
Philip Martin writes: > Stefan Fuhrmann writes: > >> On Mon, Oct 15, 2012 at 7:36 PM, Daniel Shahaf >> wrote: >> >>> (It also has the pretty odd side effect that it's not safe to run >>> 'svnadmin1.7 setrevprop' and 'svnadmin1.8 dump' concurrently on the >>> same repository...) >>> >> >> That's

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Philip Martin
Stefan Fuhrmann writes: > On Mon, Oct 15, 2012 at 7:36 PM, Daniel Shahaf wrote: > >> (It also has the pretty odd side effect that it's not safe to run >> 'svnadmin1.7 setrevprop' and 'svnadmin1.8 dump' concurrently on the >> same repository...) >> > > That's a misrepresentation of what is going o

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Stefan Fuhrmann
On Mon, Oct 15, 2012 at 7:36 PM, Daniel Shahaf wrote: > Stefan Fuhrmann wrote on Mon, Oct 15, 2012 at 19:32:57 +0200: > > On Mon, Oct 15, 2012 at 7:10 PM, Daniel Shahaf >wrote: > > > > > Daniel Shahaf wrote on Sun, Apr 29, 2012 at 12:58:56 +0300: > > > > stef...@apache.org wrote on Sun, Apr 29, 2

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread C. Michael Pilato
On 10/15/2012 01:36 PM, Daniel Shahaf wrote: > Stefan Fuhrmann wrote on Mon, Oct 15, 2012 at 19:32:57 +0200: >> On Mon, Oct 15, 2012 at 7:10 PM, Daniel Shahaf >> wrote: >>> What happens if 'svnadmin1.7 setrevprop' is run while a 1.8 server is >>> running? Will the 1.8 server miss svnadmin1.7's ch

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Mon, Oct 15, 2012 at 19:32:57 +0200: > On Mon, Oct 15, 2012 at 7:10 PM, Daniel Shahaf wrote: > > > Daniel Shahaf wrote on Sun, Apr 29, 2012 at 12:58:56 +0300: > > > stef...@apache.org wrote on Sun, Apr 29, 2012 at 09:12:49 -: > > > > Author: stefan2 > > > > Date: Sun A

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Stefan Fuhrmann
On Mon, Oct 15, 2012 at 7:10 PM, Daniel Shahaf wrote: > Daniel Shahaf wrote on Sun, Apr 29, 2012 at 12:58:56 +0300: > > stef...@apache.org wrote on Sun, Apr 29, 2012 at 09:12:49 -: > > > Author: stefan2 > > > Date: Sun Apr 29 09:12:48 2012 > > > New Revision: 1331883 > > > > > > URL: http://sv

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Daniel Shahaf
Daniel Shahaf wrote on Sun, Apr 29, 2012 at 12:58:56 +0300: > stef...@apache.org wrote on Sun, Apr 29, 2012 at 09:12:49 -: > > Author: stefan2 > > Date: Sun Apr 29 09:12:48 2012 > > New Revision: 1331883 > > > > URL: http://svn.apache.org/viewvc?rev=1331883&view=rev > > Log: > > SvnAdmin shoul

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-06-04 Thread Stefan Fuhrmann
Daniel Shahaf wrote: stef...@apache.org wrote on Sun, Apr 29, 2012 at 09:12:49 -: Author: stefan2 Date: Sun Apr 29 09:12:48 2012 New Revision: 1331883 URL: http://svn.apache.org/viewvc?rev=1331883&view=rev Log: SvnAdmin should always have revprop caching enabled such that the infrastructure

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-04-29 Thread Daniel Shahaf
stef...@apache.org wrote on Sun, Apr 29, 2012 at 09:12:49 -: > Author: stefan2 > Date: Sun Apr 29 09:12:48 2012 > New Revision: 1331883 > > URL: http://svn.apache.org/viewvc?rev=1331883&view=rev > Log: > SvnAdmin should always have revprop caching enabled such that > the infrastructure is bein