Re: svn commit: r1169851 - /subversion/trunk/subversion/tests/svn_test_main.c

2011-09-12 Thread Hyrum K Wright
Oh, I think that's a good idea! I'll go ahead and revert r1169851 now in the hopes of implementing this in the next day or so. -Hyrum On Mon, Sep 12, 2011 at 4:12 PM, Daniel Shahaf wrote: > How about having the tests use svn_error_raise_on_malfunction() by > default and svn_error_abort_on_malfu

Re: svn commit: r1169851 - /subversion/trunk/subversion/tests/svn_test_main.c

2011-09-12 Thread Daniel Shahaf
How about having the tests use svn_error_raise_on_malfunction() by default and svn_error_abort_on_malfunction() if --allow-segfaults is passed? We can then drop the --trap-assertion-failures option. Hyrum K Wright wrote on Mon, Sep 12, 2011 at 15:46:45 -0500: > It is no different than passing --t

Re: svn commit: r1169851 - /subversion/trunk/subversion/tests/svn_test_main.c

2011-09-12 Thread Hyrum K Wright
It is no different than passing --trap-assertion-failures. I didn't even know that option existed prior to your mail. However, --trap-assertion-failures has the unfortunate property that it isn't enabled by default in a standard 'make check' run, so the tests still abort() rather than continue.

Re: svn commit: r1169851 - /subversion/trunk/subversion/tests/svn_test_main.c

2011-09-12 Thread Daniel Shahaf
How is that different from using svn_error_raise_on_malfunction()? i.e., from passing --trap-assertion-failures ? hwri...@apache.org wrote on Mon, Sep 12, 2011 at 18:03:42 -: > Author: hwright > Date: Mon Sep 12 18:03:41 2011 > New Revision: 1169851 > > URL: http://svn.apache.org/viewvc?rev=