svn_checksum_to_cstring() was added in 1.6 and learnt to do this NULL check in
1.7.
I've documented the change for svn_checksum_to_cstring_display() and
added that to the STATUS entry.
Bert, Mike: if you're standing by your -0's, please let me know so I can
prepare a 1.7.0 backport patch fixing
On 07/13/2011 04:00 PM, Daniel Shahaf wrote:
> C. Michael Pilato wrote on Wed, Jul 13, 2011 at 15:54:31 -0400:
>> On 07/13/2011 03:46 PM, Daniel Shahaf wrote:
>>> cmpil...@apache.org wrote on Wed, Jul 13, 2011 at 19:28:18 -:
* r1146214
Handle NULL inputs when stringifying svn_ch
C. Michael Pilato wrote on Wed, Jul 13, 2011 at 15:54:31 -0400:
> On 07/13/2011 03:46 PM, Daniel Shahaf wrote:
> > cmpil...@apache.org wrote on Wed, Jul 13, 2011 at 19:28:18 -:
> >> * r1146214
> >> Handle NULL inputs when stringifying svn_checksum_t.
> >> @@ -38,6 +39,7 @@ Candidate chang
On 07/13/2011 03:46 PM, Daniel Shahaf wrote:
> cmpil...@apache.org wrote on Wed, Jul 13, 2011 at 19:28:18 -:
>> * r1146214
>> Handle NULL inputs when stringifying svn_checksum_t.
>> @@ -38,6 +39,7 @@ Candidate changes:
>> Avoids segfaults.
>> Votes:
>> +1: danielsh
>> +
On 07/13/2011 03:40 PM, Daniel Shahaf wrote:
> As I see it, the options are:
>
> * Pull this backport nomination. No svn_fs_verify() in 1.7.x
>
> * Backport it, and backport the implementation in 1.7.x (x >= 1)
>
> * Backport svn_fs_verify() and its implementation in 1.7.0
I see what you see,
cmpil...@apache.org wrote on Wed, Jul 13, 2011 at 19:28:18 -:
> * r1146214
> Handle NULL inputs when stringifying svn_checksum_t.
> @@ -38,6 +39,7 @@ Candidate changes:
> Avoids segfaults.
> Votes:
> +1: danielsh
> + -0: cmpilato (problem is with callers, not implement
cmpil...@apache.org wrote on Wed, Jul 13, 2011 at 19:28:18 -:
> @@ -31,6 +31,7 @@ Candidate changes:
> Votes:
> +1: danielsh, rhuijben
> -1: stsp (no-op API change)
> + -1: cmpilato (no-op API change -- will reconsider if real utility is
> added)
Well, I've since implement
7 matches
Mail list logo