Re: svn commit: r1138375 - /subversion/trunk/build/ac-macros/apache.m4

2011-06-23 Thread Philip Martin
Daniel Shahaf writes: > What if httpd or serf use apr-1.4.5 compiled with options X and > Subversion find apr-1.4.5 compiled with options Y? The user can always break things. They could build Subversion against APR and then rebuild APR with different options. I suppose we (somebody with more d

Re: svn commit: r1138375 - /subversion/trunk/build/ac-macros/apache.m4

2011-06-22 Thread Daniel Shahaf
Philip Martin wrote on Wed, Jun 22, 2011 at 15:01:34 +0100: > Arfrever Frehtes Taifersar Arahesis writes: > > >> checking whether Apache's APR is compatible configure's APR... no > >> configure: error: Apache's APR version 1.3.8 doesn't match configure's > >> 1.4.5 > >> > >> This buildbot was b

Re: svn commit: r1138375 - /subversion/trunk/build/ac-macros/apache.m4

2011-06-22 Thread Greg Stein
On Jun 22, 2011 2:34 PM, "Philip Martin" wrote: > > Greg Stein writes: > > > On Jun 22, 2011 11:24 AM, "Philip Martin" > > wrote: > >> > >> Julian Foad writes: > >> > >> > anyone wanting to mix APR versions on purpose is the "odd man out" and > >> > should expect to have to futz with the config

Re: svn commit: r1138375 - /subversion/trunk/build/ac-macros/apache.m4

2011-06-22 Thread Philip Martin
Greg Stein writes: > On Jun 22, 2011 11:24 AM, "Philip Martin" > wrote: >> >> Julian Foad writes: >> >> > anyone wanting to mix APR versions on purpose is the "odd man out" and >> > should expect to have to futz with the configuration. >> >> Does that mean manually editing configure? Or do we

Re: svn commit: r1138375 - /subversion/trunk/build/ac-macros/apache.m4

2011-06-22 Thread Greg Stein
On Jun 22, 2011 11:24 AM, "Philip Martin" wrote: > > Julian Foad writes: > > > anyone wanting to mix APR versions on purpose is the "odd man out" and > > should expect to have to futz with the configuration. > > Does that mean manually editing configure? Or do we have to provide a > configure op

Re: svn commit: r1138375 - /subversion/trunk/build/ac-macros/apache.m4

2011-06-22 Thread Julian Foad
On Wed, 2011-06-22 at 16:23 +0100, Philip Martin wrote: > Julian Foad writes: > > > anyone wanting to mix APR versions on purpose is the "odd man out" and > > should expect to have to futz with the configuration. > > Does that mean manually editing configure? Or do we have to provide a > config

Re: svn commit: r1138375 - /subversion/trunk/build/ac-macros/apache.m4

2011-06-22 Thread Philip Martin
Julian Foad writes: > anyone wanting to mix APR versions on purpose is the "odd man out" and > should expect to have to futz with the configuration. Does that mean manually editing configure? Or do we have to provide a configure option to relax the check? -- Philip

Re: svn commit: r1138375 - /subversion/trunk/build/ac-macros/apache.m4

2011-06-22 Thread Julian Foad
On Wed, 2011-06-22 at 15:01 +0100, Philip Martin wrote: > Arfrever Frehtes Taifersar Arahesis writes: > > >> checking whether Apache's APR is compatible configure's APR... no > >> configure: error: Apache's APR version 1.3.8 doesn't match configure's > >> 1.4.5 > >> > >> This buildbot was build

Re: svn commit: r1138375 - /subversion/trunk/build/ac-macros/apache.m4

2011-06-22 Thread Philip Martin
Arfrever Frehtes Taifersar Arahesis writes: >> checking whether Apache's APR is compatible configure's APR... no >> configure: error: Apache's APR version 1.3.8 doesn't match configure's 1.4.5 >> >> This buildbot was building successfully before the change. Should we >> provide a configure flag

Re: svn commit: r1138375 - /subversion/trunk/build/ac-macros/apache.m4

2011-06-22 Thread Arfrever Frehtes Taifersar Arahesis
2011-06-22 15:42:03 Philip Martin napisał(a): > Greg Stein writes: > > >>> Should we instead check that Subversion and Apache use the same APR? We > >>> could do it by checking that "apxs2 -q APR_CONFIG" matches apr_config > >>> found by configure. > >> > >> The server side needs to match httpd'

Re: svn commit: r1138375 - /subversion/trunk/build/ac-macros/apache.m4

2011-06-22 Thread Philip Martin
Greg Stein writes: >>> Should we instead check that Subversion and Apache use the same APR?  We >>> could do it by checking that "apxs2 -q APR_CONFIG" matches apr_config >>> found by configure. >> >> The server side needs to match httpd's APR. The client side can be different. >> >> Personally, I

Re: svn commit: r1138375 - /subversion/trunk/build/ac-macros/apache.m4

2011-06-22 Thread Greg Stein
[ dang: also send to dev@ ] On Wed, Jun 22, 2011 at 07:02, Greg Stein wrote: > On Wed, Jun 22, 2011 at 06:21, Philip Martin > wrote: >> phi...@apache.org writes: >> >>> Author: philip >>> Date: Wed Jun 22 10:09:17 2011 >>> New Revision: 1138375 >>> >>> URL: http://svn.apache.org/viewvc?rev=1138

Re: svn commit: r1138375 - /subversion/trunk/build/ac-macros/apache.m4

2011-06-22 Thread Philip Martin
phi...@apache.org writes: > Author: philip > Date: Wed Jun 22 10:09:17 2011 > New Revision: 1138375 > > URL: http://svn.apache.org/viewvc?rev=1138375&view=rev > Log: > * build/ac-macros/apache.m4 > (SVN_FIND_APACHE): Fix APR version checking, it was erroneously >checking for any one characte