Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-04 Thread Greg Stein
On Fri, Mar 4, 2011 at 10:34, Hyrum K Wright wrote: >... > Reverted r1076645 and added the cast in r1078008. Thanks Hyrum!

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-04 Thread Hyrum K Wright
On Thu, Mar 3, 2011 at 12:05 PM, Philip Martin wrote: > Greg Stein writes: > >> It is a lot of crap just to avoid a single cast. It makes the code >> more complicated than it needs to be. > > I don't see the cast as an improvement but I won't object if somebody > changes it (a bit like one variab

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Philip Martin
Greg Stein writes: > It is a lot of crap just to avoid a single cast. It makes the code > more complicated than it needs to be. I don't see the cast as an improvement but I won't object if somebody changes it (a bit like one variable declaration per line which I think is crap :) I'll point out

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Hyrum K Wright
On Thu, Mar 3, 2011 at 10:47 AM, Julian Foad wrote: > On Thu, 2011-03-03 at 16:33 +, Philip Martin wrote: >> Greg Stein writes: >> >> > On Thu, Mar 3, 2011 at 10:35, Hyrum K Wright wrote: >> >> On Thu, Mar 3, 2011 at 9:03 AM,   wrote: >> >>> Author: philip >> >>> Date: Thu Mar  3 15:03:42 20

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Greg Stein
On Thu, Mar 3, 2011 at 11:47, Julian Foad wrote: > On Thu, 2011-03-03 at 16:33 +, Philip Martin wrote: >> Greg Stein writes: >> >> > On Thu, Mar 3, 2011 at 10:35, Hyrum K Wright wrote: >> >> On Thu, Mar 3, 2011 at 9:03 AM,   wrote: >> >>> Author: philip >> >>> Date: Thu Mar  3 15:03:42 2011

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Julian Foad
On Thu, 2011-03-03 at 16:33 +, Philip Martin wrote: > Greg Stein writes: > > > On Thu, Mar 3, 2011 at 10:35, Hyrum K Wright wrote: > >> On Thu, Mar 3, 2011 at 9:03 AM, wrote: > >>> Author: philip > >>> Date: Thu Mar 3 15:03:42 2011 > >>> New Revision: 1076645 > >>> > >>> URL: http://svn.a

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Branko Čibej
On 03.03.2011 17:33, Philip Martin wrote: > Greg Stein writes: > >> On Thu, Mar 3, 2011 at 10:35, Hyrum K Wright wrote: >>> On Thu, Mar 3, 2011 at 9:03 AM, wrote: Author: philip Date: Thu Mar 3 15:03:42 2011 New Revision: 1076645 URL: http://svn.apache.org/viewvc?rev=1

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Philip Martin
Greg Stein writes: > On Thu, Mar 3, 2011 at 10:35, Hyrum K Wright wrote: >> On Thu, Mar 3, 2011 at 9:03 AM,   wrote: >>> Author: philip >>> Date: Thu Mar  3 15:03:42 2011 >>> New Revision: 1076645 >>> >>> URL: http://svn.apache.org/viewvc?rev=1076645&view=rev >>> Log: >>> Wrap pointer in a baton

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Greg Stein
On Thu, Mar 3, 2011 at 10:35, Hyrum K Wright wrote: > On Thu, Mar 3, 2011 at 9:03 AM,   wrote: >> Author: philip >> Date: Thu Mar  3 15:03:42 2011 >> New Revision: 1076645 >> >> URL: http://svn.apache.org/viewvc?rev=1076645&view=rev >> Log: >> Wrap pointer in a baton to avoid a complier warning or

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Hyrum K Wright
On Thu, Mar 3, 2011 at 9:03 AM, wrote: > Author: philip > Date: Thu Mar  3 15:03:42 2011 > New Revision: 1076645 > > URL: http://svn.apache.org/viewvc?rev=1076645&view=rev > Log: > Wrap pointer in a baton to avoid a complier warning or cast. I think a single cast is better than the obfuscation o