Re: svn commit: r1002470 - /subversion/trunk/subversion/svnrdump/dump_editor.c

2010-09-29 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > So, you use a top-level pool but never destroy it? > > That's not good. > > Can you please find another solution? (Either get the caller to > guarantee something about the lifetime of the pool they provide (there > is precedent for this), or figure out why clo

Re: svn commit: r1002470 - /subversion/trunk/subversion/svnrdump/dump_editor.c

2010-09-29 Thread Daniel Shahaf
So, you use a top-level pool but never destroy it? That's not good. Can you please find another solution? (Either get the caller to guarantee something about the lifetime of the pool they provide (there is precedent for this), or figure out why close_edit() isn't called (and possibly patch the f