Re: rep-cache sanity check on commit

2012-08-01 Thread Stefan Fuhrmann
On Wed, Aug 1, 2012 at 1:17 PM, Philip Martin wrote: > Stefan Fuhrmann writes: > > > On Tue, Jul 31, 2012 at 11:26 AM, Philip Martin > > > >> I suppose we might want to > >> construct the full-text corresponding to the representation to verify > >> the checksum. > > > > > > Yes. Worst thing that

Re: rep-cache sanity check on commit

2012-08-01 Thread Philip Martin
Stefan Fuhrmann writes: > On Tue, Jul 31, 2012 at 11:26 AM, Philip Martin > >> I suppose we might want to >> construct the full-text corresponding to the representation to verify >> the checksum. > > > Yes. Worst thing that might happen is a crash because > we didn't check some buffer size. combi

Re: rep-cache sanity check on commit

2012-08-01 Thread Philip Martin
Stefan Fuhrmann writes: > On Tue, Jul 31, 2012 at 11:26 AM, Philip Martin > >> We do not need to verify the whole revision or the whole >> rep-cache. >> > > I only thought that it is hard to verify that a given offset > range actually *is* a representation. To verify that, there > must be some no

Re: rep-cache sanity check on commit

2012-08-01 Thread Stefan Fuhrmann
On Tue, Jul 31, 2012 at 11:26 AM, Philip Martin wrote: > Stefan Fuhrmann writes: > > > On Mon, Jul 30, 2012 at 12:40 PM, Philip Martin > > wrote: > > > >> When the commit process finds a representation in the rep-cache the only > >> sanity check that happens is that the revision must be less than

Re: rep-cache sanity check on commit

2012-07-31 Thread Philip Martin
Stefan Fuhrmann writes: > On Mon, Jul 30, 2012 at 12:40 PM, Philip Martin > wrote: > >> When the commit process finds a representation in the rep-cache the only >> sanity check that happens is that the revision must be less than or >> equal to HEAD. We don't check that the offset is valid: >> >>

Re: rep-cache sanity check on commit

2012-07-31 Thread Philip Martin
Philip Martin writes: > When the commit process finds a representation in the rep-cache the only > sanity check that happens is that the revision must be less than or > equal to HEAD. This check is a bit worrying. The check is supposed to handle the case where the rep-cache is newer than the re

Re: rep-cache sanity check on commit

2012-07-31 Thread Stefan Fuhrmann
On Mon, Jul 30, 2012 at 12:40 PM, Philip Martin wrote: > When the commit process finds a representation in the rep-cache the only > sanity check that happens is that the revision must be less than or > equal to HEAD. We don't check that the offset is valid: > > echo foo > foo > svnadmin create

rep-cache sanity check on commit

2012-07-30 Thread Philip Martin
When the commit process finds a representation in the rep-cache the only sanity check that happens is that the revision must be less than or equal to HEAD. We don't check that the offset is valid: echo foo > foo svnadmin create repo svn import -mm foo file://`pwd`/repo/A/f sqlite3 repo/db/rep