Re: r1397773 - rep-sharing in a txn - subversion/libsvn_fs_fs/fs_fs.c

2012-11-25 Thread Stefan Fuhrmann
On Mon, Nov 19, 2012 at 7:30 PM, Ben Reser wrote: > On Mon, Nov 19, 2012 at 6:43 AM, Stefan Fuhrmann > wrote: > > A crashed writer process may leave a corrupt protorev and / or > > other incomplete files. There is no atomic incremental change > > here. The caller (client) using the crashed proce

Re: r1397773 - rep-sharing in a txn - subversion/libsvn_fs_fs/fs_fs.c

2012-11-19 Thread Ben Reser
On Mon, Nov 19, 2012 at 6:43 AM, Stefan Fuhrmann wrote: > A crashed writer process may leave a corrupt protorev and / or > other incomplete files. There is no atomic incremental change > here. The caller (client) using the crashed process is supposed > to detect the crash and abandon the transacti

Re: r1397773 - rep-sharing in a txn - subversion/libsvn_fs_fs/fs_fs.c

2012-11-19 Thread Daniel Shahaf
Julian Foad wrote on Mon, Nov 19, 2012 at 15:16:44 +: > Stefan Fuhrmann wrote: > > relatively rare and constructing an error object can be > > expensive (NLS). svn_stringbuf_from_file2 is also a very > > convenient function to use. > I wonder if we could change our generic error handling scheme

Re: r1397773 - rep-sharing in a txn - subversion/libsvn_fs_fs/fs_fs.c

2012-11-19 Thread Stefan Fuhrmann
On Mon, Nov 19, 2012 at 4:16 PM, Julian Foad wrote: > > Stefan Fuhrmann wrote: > > > Thanks for the review! The code should be multi-thread safe. > > hm. That should read "should be multi-thread safe *now*". -- Stefan^2. -- Certified & Supported Apache Subversion Downloads: * http://www.wandis

Re: r1397773 - rep-sharing in a txn - subversion/libsvn_fs_fs/fs_fs.c

2012-11-19 Thread Julian Foad
Stefan Fuhrmann wrote: On Thu, Nov 15, 2012 at 6:16 PM, Julian Foad wrote: >>stef...@apache.org wrote: >>> URL: http://svn.apache.org/viewvc?rev=1397773&view=rev >>> Log: >>> Due to public request: apply rep-sharing to equal data reps within >>> the same transaction. >>> >>> The idea is simple. W

Re: r1397773 - rep-sharing in a txn - subversion/libsvn_fs_fs/fs_fs.c

2012-11-19 Thread Stefan Fuhrmann
On Thu, Nov 15, 2012 at 6:16 PM, Julian Foad wrote: > Hi Stefan. Some review questions and comments... > > stef...@apache.org wrote: > > URL: http://svn.apache.org/viewvc?rev=1397773&view=rev > > Log: > > Due to public request: apply rep-sharing to equal data reps within > > the same transaction.

Re: r1397773 - rep-sharing in a txn - subversion/libsvn_fs_fs/fs_fs.c

2012-11-15 Thread Julian Foad
Hi Stefan.  Some review questions and comments... stef...@apache.org wrote: > URL: http://svn.apache.org/viewvc?rev=1397773&view=rev > Log: > Due to public request: apply rep-sharing to equal data reps within > the same transaction. > > The idea is simple. When writing a noderev to the txn folde