RE: problems with mimetype of and empty utf8 files in svn 1.7

2011-11-18 Thread Schmied, Fabian
> > Is it okay to create an issue in > > the issue tracker that we could watch? > > Absolutely. You can assign this issue to me, set the milestone to 1.7.x, and > I'll > deal with it when I find time. Thank you. Here it is: "http://subversion.tigris.org/issues/show_bug.cgi?id=4064";. Thanks, Fa

Re: problems with mimetype of and empty utf8 files in svn 1.7

2011-11-18 Thread Stefan Sperling
On Fri, Nov 18, 2011 at 11:18:55AM +, Schmied, Fabian wrote: > Sorry for jumping in; but since we're affected by this issue, too, I > just want to ask: Is this now planned to be changed (fixed) for one of > the upcoming releases of Subversion? Yes. It just fell through the cracks. Thanks for p

Re: problems with mimetype of and empty utf8 files in svn 1.7

2011-11-18 Thread Schmied, Fabian
> > Have you considered patchign svn_io_is_binary_data()? > > > > (which, it appears, will be functionally equivalent to your current > > patch) > > > Yeah, makes sense. Do that if you prefer. > (regarding Bert's patch problem: looks like a bug to me, too) Sorry for jumping in; but since w

Re: problems with mimetype of and empty utf8 files in svn 1.7

2011-10-21 Thread Stefan Sperling
On Fri, Oct 21, 2011 at 01:34:15PM +0200, 'Daniel Shahaf' wrote: > Have you considered patchign svn_io_is_binary_data()? > > (which, it appears, will be functionally equivalent to your current > patch) Yeah, makes sense. Do that if you prefer. (regarding Bert's patch problem: looks like a bug to

Re: problems with mimetype of and empty utf8 files in svn 1.7

2011-10-21 Thread Tomáš Bihary
To be honest, I expect that a C# source code will be handled as a text file. Even if it is empty at the point of the ADD operation. The backgound is that this happens in combination VS2008/2010 - Resharper - VisualSVN - TortioseSVN. If you do in Resharper the rectoring "Move the class to new f

Re: problems with mimetype of and empty utf8 files in svn 1.7

2011-10-21 Thread 'Daniel Shahaf'
oktober 2011 13:13 > > > To: Tomáš Bihary > > > Cc: dev@subversion.apache.org > > > Subject: Re: problems with mimetype of and empty utf8 files in svn 1.7 > > > > > > What do you expect to happen? > > > > > > As to special-casing svn_io_is

Re: problems with mimetype of and empty utf8 files in svn 1.7

2011-10-21 Thread Stefan Sperling
Subject: Re: problems with mimetype of and empty utf8 files in svn 1.7 > > > > What do you expect to happen? > > > > As to special-casing svn_io_is_binary_data() to handle 0xEFBBBF > > correctly... we could do that, I suppose. > > +1 > AnkhSVN currently has

Re: problems with mimetype of and empty utf8 files in svn 1.7

2011-10-21 Thread Tomáš Bihary
Hi, Yes you are right, SVN 1.6.16 doest it as well, so it's not a 1.7 new issue. There is just different behaviour for such file in the TortioseSVN Comit Dialog, so I didn't realized it before - 1.6 does not display any property status - you have to take a look on the properties and there is t

RE: problems with mimetype of and empty utf8 files in svn 1.7

2011-10-21 Thread Bert Huijben
> -Original Message- > From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] > Sent: vrijdag 21 oktober 2011 13:13 > To: Tomáš Bihary > Cc: dev@subversion.apache.org > Subject: Re: problems with mimetype of and empty utf8 files in svn 1.7 > > What do you expe

Re: problems with mimetype of and empty utf8 files in svn 1.7

2011-10-21 Thread Daniel Shahaf
What do you expect to happen? As to special-casing svn_io_is_binary_data() to handle 0xEFBBBF correctly... we could do that, I suppose. Tomáš Bihary wrote on Fri, Oct 21, 2011 at 11:15:19 +0200: > Hello, > > after upgrading the svn 1.7 I realized an issue. > > When I add an empty UTF-8 file, it

Re: problems with mimetype of and empty utf8 files in svn 1.7

2011-10-21 Thread Stefan Sperling
On Fri, Oct 21, 2011 at 11:15:19AM +0200, Tomáš Bihary wrote: > Hello, > > after upgrading the svn 1.7 I realized an issue. > > When I add an empty UTF-8 file, it is added with mimetype > application/octet-stream > The empty UTF8 file has 3 bytes size - there are just the 3 mark > bytes 0xEF 0xBB

problems with mimetype of and empty utf8 files in svn 1.7

2011-10-21 Thread Tomáš Bihary
Hello, after upgrading the svn 1.7 I realized an issue. When I add an empty UTF-8 file, it is added with mimetype application/octet-stream The empty UTF8 file has 3 bytes size - there are just the 3 mark bytes 0xEF 0xBB 0xBF If there is an content in that file, it is handled correctly like t