Re: handling of reparse points

2018-06-08 Thread Stefan Kueng
On 08.06.2018 00:30, Branko Čibej wrote: Just FYI: in that case svn would have a requirement for NTFS. Because both hard links (for files) and junctions (for directories) only work on NTFS. So it wouldn't be possible anymore to use svn on e.g. a usb stick formatted with FAT32. Yes ... we'd

Re: handling of reparse points

2018-06-07 Thread Philip Martin
Branko Čibej writes: >> We do use that flag, but — just like cross-device copies on Unix — the >> move is no longer atomic, which could break the working copy quite badly. > > I mean cross-device moves, of course, not copies. svn_io_file_move() is our wrapper that is intended to make it work: it

Re: handling of reparse points

2018-06-07 Thread Branko Čibej
On 08.06.2018 00:30, Branko Čibej wrote: > On 07.06.2018 18:50, Stefan Kueng wrote: >> >> On 05.06.2018 23:35, Philip Martin wrote: >>> Stefan Küng writes: >>> Index: subversion/libsvn_subr/io.c === --- subversion/libsv

Re: handling of reparse points

2018-06-07 Thread Branko Čibej
On 07.06.2018 18:50, Stefan Kueng wrote: > > > On 05.06.2018 23:35, Philip Martin wrote: >> Stefan Küng writes: >> >>> Index: subversion/libsvn_subr/io.c >>> === >>> --- subversion/libsvn_subr/io.c    (revision 1831874) >>> +++ subver

Re: handling of reparse points

2018-06-07 Thread Stefan Kueng
On 05.06.2018 23:35, Philip Martin wrote: Stefan Küng writes: Index: subversion/libsvn_subr/io.c === --- subversion/libsvn_subr/io.c (revision 1831874) +++ subversion/libsvn_subr/io.c (working copy) @@ -342,8 +342,11 @@ /* N

Re: handling of reparse points

2018-06-05 Thread Philip Martin
Stefan Küng writes: > Index: subversion/libsvn_subr/io.c > === > --- subversion/libsvn_subr/io.c (revision 1831874) > +++ subversion/libsvn_subr/io.c (working copy) > @@ -342,8 +342,11 @@ >/* Not using svn_io_stat() h

Re: handling of reparse points

2018-06-05 Thread Stefan Küng
On Sat, May 26, 2018 at 7:35 AM Stefan Küng wrote: > Next try, patch attached. > Basically what this does is to never check for soft/hard links on Windows > ever. Since Subversion doesn't really handle those on Windows anyway, > checking for them doesn't make sense and causes problems. > > I've d

Re: handling of reparse points

2018-06-05 Thread emmawatson8855
Johan Corveleyn-3 wrote > On Sat, May 26, 2018 at 9:42 AM, Branko Čibej < > brane@ > > wrote: >> On 25.05.2018 20:30, Stefan Kueng wrote: >>> >>> >>> On 25.05.2018 18:07, Daniel Shahaf wrote: Stefan Küng wrote on Fri, 25 May 2018 17:37 +0200: > Can anyone comment on this please? >>>

Re: handling of reparse points

2018-05-28 Thread Johan Corveleyn
On Sat, May 26, 2018 at 9:42 AM, Branko Čibej wrote: > On 25.05.2018 20:30, Stefan Kueng wrote: >> >> >> On 25.05.2018 18:07, Daniel Shahaf wrote: >>> Stefan Küng wrote on Fri, 25 May 2018 17:37 +0200: Can anyone comment on this please? >>> >>> I'm not familiar with the Windows side of things

Re: handling of reparse points

2018-05-26 Thread Branko Čibej
On 25.05.2018 20:30, Stefan Kueng wrote: > > > On 25.05.2018 18:07, Daniel Shahaf wrote: >> Stefan Küng wrote on Fri, 25 May 2018 17:37 +0200: >>> Can anyone comment on this please? >> >> I'm not familiar with the Windows side of things, but I gave the >> patch a spin. > > And I'm not familiar with

Re: handling of reparse points

2018-05-25 Thread Stefan Küng
Next try, patch attached. Basically what this does is to never check for soft/hard links on Windows ever. Since Subversion doesn't really handle those on Windows anyway, checking for them doesn't make sense and causes problems. I've done some testing with this patch and it seems to work fine. Ste

Re: handling of reparse points

2018-05-25 Thread Stefan Kueng
On 25.05.2018 18:07, Daniel Shahaf wrote: Stefan Küng wrote on Fri, 25 May 2018 17:37 +0200: Can anyone comment on this please? I'm not familiar with the Windows side of things, but I gave the patch a spin. And I'm not familiar with soft/hardlinks on Linux. :) If I do 'mv .svn x; ln -s x

Re: handling of reparse points

2018-05-25 Thread Daniel Shahaf
Stefan Küng wrote on Fri, 25 May 2018 17:37 +0200: > Can anyone comment on this please? I'm not familiar with the Windows side of things, but I gave the patch a spin. If I do 'mv .svn x; ln -s x .svn', things seem to work. However, if the target of the '.svn' symlink isn't in the same directory

Re: handling of reparse points

2018-05-25 Thread Stefan Küng
Can anyone comment on this please? On Fri, May 18, 2018 at 10:29 PM Stefan Kueng wrote: > Hi, > > It seems that svn doesn't handle reparse points properly in all > situations. Which causes big problems for TSVN when a working copy is on > a Onedrive folder. > > See here for more details: > https

handling of reparse points

2018-05-18 Thread Stefan Kueng
Hi, It seems that svn doesn't handle reparse points properly in all situations. Which causes big problems for TSVN when a working copy is on a Onedrive folder. See here for more details: https://groups.google.com/d/msg/tortoisesvn/hlQj5OifhBg/RX_cw_sQCgAJ While in this particular situation,