Re: errorcode.inc in tarballs

2017-08-10 Thread James McCoy
On Aug 10, 2017 15:29, "Philip Martin" wrote: Branko Čibej writes: > Would be better to generate this header at build time ... but to do that > in a cross-platform manner, we'd have to write a C program to do that. Even that is hard, I know of no easy way for C code to convert an error number

Re: errorcode.inc in tarballs

2017-08-10 Thread Philip Martin
Branko Čibej writes: > Would be better to generate this header at build time ... but to do that > in a cross-platform manner, we'd have to write a C program to do that. Even that is hard, I know of no easy way for C code to convert an error number into a symbolic name. Going from names to numbe

Re: errorcode.inc in tarballs

2017-08-10 Thread Daniel Shahaf
Branko Čibej wrote on Thu, 10 Aug 2017 11:04 +0200: > On 09.08.2017 23:40, Philip Martin wrote: > > To an extent the change is trivial, this code is only used in SVN_DEBUG > > builds and even then it doesn't have much effect on how Subversion > > works. > > > > Arguably more important is having our

Re: errorcode.inc in tarballs

2017-08-10 Thread Branko Čibej
On 09.08.2017 23:40, Philip Martin wrote: > I recently modified release.py and this has meant I have been recreating > old tarballs to test my changes. This has highlighted the file > > subversion/libsvn_subr/errorcode.inc > > which is generated by gen-make.py, has content that is produced via >

errorcode.inc in tarballs

2017-08-09 Thread Philip Martin
I recently modified release.py and this has meant I have been recreating old tarballs to test my changes. This has highlighted the file subversion/libsvn_subr/errorcode.inc which is generated by gen-make.py, has content that is produced via Python's errno module with the result that the tarbal