Re: bug in can_modify()

2012-05-17 Thread Greg Stein
On May 17, 2012 1:04 PM, "Hyrum K Wright" wrote: > > On Thu, May 17, 2012 at 11:00 AM, Greg Stein wrote: >... > > I got my Ev2 branch going last night, and got about 20 failures. Does that > > sound right? > > Over ra_local, I only see the following 3 failures: > FAIL: blame_tests.py 7: blame wi

Re: bug in can_modify()

2012-05-17 Thread Hyrum K Wright
On Thu, May 17, 2012 at 11:00 AM, Greg Stein wrote: > > On May 17, 2012 11:53 AM, "Hyrum K Wright" > wrote: >> >> On Wed, May 16, 2012 at 11:27 PM, Greg Stein wrote: >>... > >> > Right. The add/copy should fail because the node already exists. I >> > relied on >> > that failure, rather than issu

Re: bug in can_modify()

2012-05-17 Thread Greg Stein
On May 17, 2012 11:53 AM, "Hyrum K Wright" wrote: > > On Wed, May 16, 2012 at 11:27 PM, Greg Stein wrote: >... > > Right. The add/copy should fail because the node already exists. I relied on > > that failure, rather than issuing an OOD. We could add that empty-target > > verification. > > I thin

Re: bug in can_modify()

2012-05-17 Thread Hyrum K Wright
On Wed, May 16, 2012 at 11:27 PM, Greg Stein wrote: > > On May 15, 2012 6:04 PM, "Hyrum K Wright" wrote: >>... > > >> This research comes as a result of the final test failures on the >> ev2-export branch for commit: tree conflicts tests 4 and 8.  Both of >> these set up the tree conflict scenari

Re: bug in can_modify()

2012-05-16 Thread Greg Stein
On May 15, 2012 6:04 PM, "Hyrum K Wright" wrote: >... > This research comes as a result of the final test failures on the > ev2-export branch for commit: tree conflicts tests 4 and 8. Both of > these set up the tree conflict scenario, and in doing so occasionally > expect an out-of-date error, wh

bug in can_modify()

2012-05-15 Thread Hyrum K Wright
Greg, I think can_modify() (or it's uses) aren't quite correct. I don't yet have a solution to the problem, but figured I'd record my progress here, to see if anybody else has ideas. For the uninitiated, can_modify() is essentially the out-of-dateness checker for the Ev2-style interface to libsvn