Re: branching 1.14.x

2020-03-16 Thread Stefan Sperling
On Mon, Mar 16, 2020 at 12:26:18AM -0400, James McCoy wrote: > On Sat, Mar 14, 2020 at 10:32:04AM -0400, James McCoy wrote: > > I'm working on it now. I should be able to have something that avoids > > regressions on Windows this weekend. > > Done in r1875230. Thanks James. Looks good to me. Ba

Re: branching 1.14.x

2020-03-15 Thread James McCoy
On Sat, Mar 14, 2020 at 10:32:04AM -0400, James McCoy wrote: > On Sat, Mar 14, 2020 at 03:26:48PM +0100, Stefan Sperling wrote: > > On Sat, Mar 14, 2020 at 10:12:41AM -0400, Mark Phippard wrote: > > > My only advice would be to reach a point where we accept no one is going > > > to > > > step up a

Re: branching 1.14.x

2020-03-14 Thread Nathan Hartman
On Sat, Mar 14, 2020 at 10:30 AM Julian Foad wrote: > Stefan Sperling wrote: > > We also need people to test and sign the releases across OS platforms. > > At a minimum there will be 1.14.0-rc1 and 1.14.0 releases to test and > sign. > > I expect to be able to test and sign on Linux. Looks like

Re: branching 1.14.x

2020-03-14 Thread Mark Phippard
> On Mar 14, 2020, at 12:06 PM, Stefan Sperling wrote: > > On Sat, Mar 14, 2020 at 02:16:51PM +, Julian Foad wrote: >> Mark Phippard wrote: >>> Anyway, I am just trying to suggest things to help us get unstuck. >> >> Agreed. Stefan, other readers may read it differently, but I found Mark's

Re: branching 1.14.x

2020-03-14 Thread Daniel Shahaf
Stefan Sperling wrote on Sat, 14 Mar 2020 16:59 +0100: > On Sat, Mar 14, 2020 at 03:47:44PM +, Daniel Shahaf wrote: > > What is it that I'm supposed to share my assessment of? My involvement > > in shelving consisted of little more than conducting two commit > > reviews. > > Whether you're

Re: branching 1.14.x

2020-03-14 Thread Stefan Sperling
On Sat, Mar 14, 2020 at 02:16:51PM +, Julian Foad wrote: > Mark Phippard wrote: > > Anyway, I am just trying to suggest things to help us get unstuck. > > Agreed. Stefan, other readers may read it differently, but I found Mark's > input here to be useful and on-topic, as well as bluntly direc

Re: branching 1.14.x

2020-03-14 Thread Stefan Sperling
On Sat, Mar 14, 2020 at 03:47:44PM +, Daniel Shahaf wrote: > What is it that I'm supposed to share my assessment of? My involvement > in shelving consisted of little more than conducting two commit > reviews. Whether you're OK with that code you've reviewed to be shipped as it is. It sounds l

Re: branching 1.14.x

2020-03-14 Thread Mark Phippard
> On Mar 14, 2020, at 11:42 AM, Daniel Shahaf wrote: > > Stefan Sperling wrote on Sat, 14 Mar 2020 15:00 +0100: >>> On Sat, Mar 14, 2020 at 09:25:21AM -0400, Mark Phippard wrote: >>> OK, then let's just move past it and hope it gets fixed in APR? If no one >>> raises their hand saying they are w

Re: branching 1.14.x

2020-03-14 Thread Daniel Shahaf
Stefan Sperling wrote on Sat, 14 Mar 2020 15:26 +0100: > On Sat, Mar 14, 2020 at 10:12:41AM -0400, Mark Phippard wrote: > > I do not fully understand where we are at on shelving. I believe ideas were > > proposed to make it a compile time feature that would be off by default or > > something. I am

Re: branching 1.14.x

2020-03-14 Thread Daniel Shahaf
Stefan Sperling wrote on Sat, 14 Mar 2020 15:00 +0100: > On Sat, Mar 14, 2020 at 09:25:21AM -0400, Mark Phippard wrote: > > OK, then let's just move past it and hope it gets fixed in APR? If no one > > raises their hand saying they are working on a fix, you should proceed as if > > we are never goi

Re: branching 1.14.x

2020-03-14 Thread Mark Phippard
> On Mar 14, 2020, at 10:32 AM, James McCoy wrote: > > On Sat, Mar 14, 2020 at 03:26:48PM +0100, Stefan Sperling wrote: >>> On Sat, Mar 14, 2020 at 10:12:41AM -0400, Mark Phippard wrote: >>> My only advice would be to reach a point where we accept no one is going to >>> step up and fix this on W

Re: branching 1.14.x

2020-03-14 Thread Stefan Sperling
On Sat, Mar 14, 2020 at 10:32:04AM -0400, James McCoy wrote: > I'm working on it now. I should be able to have something that avoids > regressions on Windows this weekend. > > Cheers, > -- > James > GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB Great news. Thank you James!

Re: branching 1.14.x

2020-03-14 Thread James McCoy
On Sat, Mar 14, 2020 at 03:26:48PM +0100, Stefan Sperling wrote: > On Sat, Mar 14, 2020 at 10:12:41AM -0400, Mark Phippard wrote: > > My only advice would be to reach a point where we accept no one is going to > > step up and fix this on Windows and then decide accordingly. If we can fix > > it >

Re: branching 1.14.x

2020-03-14 Thread Julian Foad
Stefan Sperling wrote: We also need people to test and sign the releases across OS platforms. At a minimum there will be 1.14.0-rc1 and 1.14.0 releases to test and sign. I expect to be able to test and sign on Linux. - Julian

Re: branching 1.14.x

2020-03-14 Thread Stefan Sperling
On Sat, Mar 14, 2020 at 10:12:41AM -0400, Mark Phippard wrote: > I do not fully understand where we are at on shelving. I believe ideas were > proposed to make it a compile time feature that would be off by default or > something. I am fine with that. You raised it as being a blocker still so I > a

Re: branching 1.14.x

2020-03-14 Thread Julian Foad
Mark Phippard wrote: Stefan Sperling wrote: 1. The 'decouple-shelving-cli' branch 2. The editor path fixes which don't yet work on Windows. Since nobody has responded: Should I just make a decision by myself? The 'decouple-shelving-cli' branch is merged and working: the experimental shelvi

Re: branching 1.14.x

2020-03-14 Thread Mark Phippard
> > Nobody is trying to hold up anything. The common goal is to get 1.14 > shipped ASAP. At least I haven't seen anyone saying otherwise. I know that no one is actively trying to hold up the release, on the contrary we are trying to get it wrapped. I am speaking to the extent these items are st

Re: branching 1.14.x

2020-03-14 Thread Stefan Sperling
On Sat, Mar 14, 2020 at 09:25:21AM -0400, Mark Phippard wrote: > > On Mar 14, 2020, at 8:51 AM, Stefan Sperling wrote: > > On Sat, Mar 14, 2020 at 08:03:28AM -0400, Mark Phippard wrote: > > I don't think asking "why are we even doing this" is helpful. > > That is pretty unfair. I could go back

Re: branching 1.14.x

2020-03-14 Thread Mark Phippard
> On Mar 14, 2020, at 8:51 AM, Stefan Sperling wrote: > > On Sat, Mar 14, 2020 at 08:03:28AM -0400, Mark Phippard wrote: >> Personally, I do not care at all about experimental features and shelving. I >> would favor ripping it all out and let it come back in a future release if >> someone wants

Re: branching 1.14.x

2020-03-14 Thread Stefan Sperling
On Sat, Mar 14, 2020 at 08:03:28AM -0400, Mark Phippard wrote: > Personally, I do not care at all about experimental features and shelving. I > would favor ripping it all out and let it come back in a future release if > someone wants to finish and turn it into a feature that we are willing to > s

Re: branching 1.14.x

2020-03-14 Thread Mark Phippard
> On Mar 14, 2020, at 7:47 AM, Stefan Sperling wrote: > > On Tue, Mar 10, 2020 at 12:23:49PM +0100, Stefan Sperling wrote: >> As previously discussed, I would like to create the 1.14.x branch >> soon in order to begin the release process for 1.14.0. >> >> There are two changes being worked on w

Re: branching 1.14.x

2020-03-14 Thread Stefan Sperling
On Tue, Mar 10, 2020 at 12:23:49PM +0100, Stefan Sperling wrote: > As previously discussed, I would like to create the 1.14.x branch > soon in order to begin the release process for 1.14.0. > > There are two changes being worked on which look important and > which, I believe, could only be introdu

branching 1.14.x

2020-03-10 Thread Stefan Sperling
As previously discussed, I would like to create the 1.14.x branch soon in order to begin the release process for 1.14.0. There are two changes being worked on which look important and which, I believe, could only be introduced in a dot zero release since they violate our patch release compatibilit