Re: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Ivan Zhakov
On 11 December 2015 at 04:12, Branko Čibej wrote: > On 10.12.2015 18:23, Ivan Zhakov wrote: >> I think returning >> hash with non-standard hash function from public API is a bug (and API >> regression). Other API users may get to the same situation. So proper >> fix would be revert these optimizat

Re: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Ivan Zhakov
On 11 December 2015 at 06:18, William A Rowe Jr wrote: > Which public API, APR's or svn's? > Subversion's. Sorry I forgot that dev@a.a.o list is in cc. -- Ivan Zhakov

Re: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread William A Rowe Jr
Which public API, APR's or svn's? On Dec 10, 2015 11:24 AM, "Ivan Zhakov" wrote: > On 10 December 2015 at 20:20, Julian Foad wrote: > > Ivan Zhakov wrote: > >> On 10 December 2015 at 19:14, Julian Foad > wrote: > >>> APR devs, Subversion devs: > >>> > >>> On Subversion's Mac OS buildbots it ap

Re: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Branko Čibej
On 10.12.2015 18:23, Ivan Zhakov wrote: > I think returning > hash with non-standard hash function from public API is a bug (and API > regression). Other API users may get to the same situation. So proper > fix would be revert these optimizations from public API imo. I really can't agree with this

Re: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Stefan Fuhrmann
On 10.12.2015 18:23, Ivan Zhakov wrote: On 10 December 2015 at 20:20, Julian Foad wrote: Ivan Zhakov wrote: On 10 December 2015 at 19:14, Julian Foad wrote: APR devs, Subversion devs: On Subversion's Mac OS buildbots it appears that apr_hash_overlay() sometimes returns a hash containing d

Re: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Ivan Zhakov
On 10 December 2015 at 20:20, Julian Foad wrote: > Ivan Zhakov wrote: >> On 10 December 2015 at 19:14, Julian Foad wrote: >>> APR devs, Subversion devs: >>> >>> On Subversion's Mac OS buildbots it appears that apr_hash_overlay() >>> sometimes returns a hash containing duplicate keys, which (as I

Re: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Julian Foad
Ivan Zhakov wrote: > On 10 December 2015 at 19:14, Julian Foad wrote: >> APR devs, Subversion devs: >> >> On Subversion's Mac OS buildbots it appears that apr_hash_overlay() >> sometimes returns a hash containing duplicate keys, which (as I >> understand it) should be impossible. >> >> We had an

RE: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Bert Huijben
Windows 10 phone From: Julian Foad Sent: donderdag 10 december 2015 17:15 To: APR devel Cc: dev Subject: apr_hash_overlay returns hash with duplicate keys APR devs, Subversion devs: On Subversion's Mac OS buildbots it appears that apr_hash_overlay() sometimes returns a hash containing duplicate

Re: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Ivan Zhakov
On 10 December 2015 at 19:14, Julian Foad wrote: > APR devs, Subversion devs: > > On Subversion's Mac OS buildbots it appears that apr_hash_overlay() > sometimes returns a hash containing duplicate keys, which (as I > understand it) should be impossible. > > We had an issue where some 'svnmover' t

apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Julian Foad
APR devs, Subversion devs: On Subversion's Mac OS buildbots it appears that apr_hash_overlay() sometimes returns a hash containing duplicate keys, which (as I understand it) should be impossible. We had an issue where some 'svnmover' tests were failing only on Mac OS buildbots. I added some debug