Re: Warning for missing sentinel arguments

2013-11-20 Thread Julian Foad
Branko Čibej wrote: > On 19.11.2013 18:19, Julian Foad wrote: >> [...] I was referring to the change of SVN_NO_ERROR from '0' to '(void *)0'. > I hope you mean (svn_error_t*)0, not (void*)0? Oops, yes I did mean that. >> But now I see that the real issue with svn_cl__try is its variable argumen

Re: Warning for missing sentinel arguments

2013-11-19 Thread Branko Čibej
On 19.11.2013 18:19, Julian Foad wrote: > Bert Huijben wrote: > >>> Bert Huijben wrote: Julian Foad wrote: > On 11/18/13 3:03 PM, Julian Foad wrote: >> The patch also changes SVN_NO_ERROR from "0" to "((svn_error_t*)0)". >> This has the side effect of detecting other mis-uses: I co

Re: Warning for missing sentinel arguments

2013-11-19 Thread Julian Foad
Bert Huijben wrote: >> Bert Huijben wrote: >>> Julian Foad wrote: On 11/18/13 3:03 PM, Julian Foad wrote: > The patch also changes SVN_NO_ERROR from "0" to "((svn_error_t*)0)". > This has the side effect of detecting other mis-uses: I committed two such > fixes as http://svn.apach

RE: Warning for missing sentinel arguments

2013-11-19 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: dinsdag 19 november 2013 13:23 > To: 'Julian Foad'; 'Ben Reser' > Cc: dev@subversion.apache.org > Subject: RE: Warning for missing sentinel arguments > > > >

RE: Warning for missing sentinel arguments

2013-11-19 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julianf...@btopenworld.com] > Sent: dinsdag 19 november 2013 12:39 > To: Ben Reser > Cc: dev@subversion.apache.org > Subject: Re: Warning for missing sentinel arguments > > > On 11/18/13 3:03 PM, Julian Foad wr

Re: Warning for missing sentinel arguments

2013-11-19 Thread Julian Foad
> On 11/18/13 3:03 PM, Julian Foad wrote: >> The patch also changes SVN_NO_ERROR from "0" to "((svn_error_t *)0)". This >> has the side effect of detecting other mis-uses: I committed two such fixes >> as http://svn.apache.org/r1543193 and http://svn.apache.org/r1543216 . I >> can't think of any n

Re: Warning for missing sentinel arguments

2013-11-18 Thread Ben Reser
On 11/18/13 3:03 PM, Julian Foad wrote: > If no objections I'll commit tomorrow. On further thinking I don't think SWIG should be excluded in this case. It makes sense to exclude it from the SVN_DEPRECATED warnings with SWIG because we expect the SWIG bindings to implement deprecated functions fo

Warning for missing sentinel arguments

2013-11-18 Thread Julian Foad
Following r1543145, the attached patch adds __attribute__((sentinel)) to functions that require a null sentinel argument, to make GCC warn if the argument is missing. Via a macro so only for GCC >= 4.0. (I don't see an equivalent attribute for MSC but if there is one we can add it.) The patch also