Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-05 Thread Daniel Shahaf
Greg Stein wrote on Thu, Apr 05, 2012 at 20:18:38 -0400: > If we don't find the bugfix doable, then I think we can/should add the > check that I researched above. > +1

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-05 Thread Greg Stein
On Apr 5, 2012 4:16 PM, "Daniel Shahaf" wrote: >... > Yeah, the alternative is to do it at compile-time and disallow > the `--with-berkeley-db --with-apxs=2.4' combination --- even for people > who don't have BDB repositories. Not sure about this; I think the get_resource() fix would be preferabl

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-05 Thread Daniel Shahaf
Greg Stein wrote on Thu, Apr 05, 2012 at 15:02:35 -0400: > On Thu, Apr 5, 2012 at 14:46, Greg Stein wrote: > > On Thu, Apr 5, 2012 at 14:21, Daniel Shahaf wrote: > >> Greg Stein wrote on Thu, Apr 05, 2012 at 14:14:53 -0400: > >>> On Apr 5, 2012 2:10 PM, "Daniel Shahaf" wrote: > >>> > > >>> > Gre

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-05 Thread Greg Stein
On Thu, Apr 5, 2012 at 14:46, Greg Stein wrote: > On Thu, Apr 5, 2012 at 14:21, Daniel Shahaf wrote: >> Greg Stein wrote on Thu, Apr 05, 2012 at 14:14:53 -0400: >>> On Apr 5, 2012 2:10 PM, "Daniel Shahaf" wrote: >>> > >>> > Greg Stein wrote on Thu, Apr 05, 2012 at 14:05:31 -0400: >>> > > On Apr

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-05 Thread Greg Stein
On Thu, Apr 5, 2012 at 14:21, Daniel Shahaf wrote: > Greg Stein wrote on Thu, Apr 05, 2012 at 14:14:53 -0400: >> On Apr 5, 2012 2:10 PM, "Daniel Shahaf" wrote: >> > >> > Greg Stein wrote on Thu, Apr 05, 2012 at 14:05:31 -0400: >> > > On Apr 5, 2012 6:46 AM, "Philip Martin" >> wrote: >> > >>

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-05 Thread Philip Martin
Greg Stein writes: > On Apr 5, 2012 2:10 PM, "Daniel Shahaf" wrote: >> >> Greg Stein wrote on Thu, Apr 05, 2012 at 14:05:31 -0400: >> > On Apr 5, 2012 6:46 AM, "Philip Martin" > wrote: >> >> > > >> > > I've raised issue 4157 to track this problem. >> > >> > Can we at least implement a dete

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-05 Thread Daniel Shahaf
Greg Stein wrote on Thu, Apr 05, 2012 at 14:14:53 -0400: > On Apr 5, 2012 2:10 PM, "Daniel Shahaf" wrote: > > > > Greg Stein wrote on Thu, Apr 05, 2012 at 14:05:31 -0400: > > > On Apr 5, 2012 6:46 AM, "Philip Martin" > wrote: > > > > > > > > > > I've raised issue 4157 to track this problem.

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-05 Thread Greg Stein
On Apr 5, 2012 2:10 PM, "Daniel Shahaf" wrote: > > Greg Stein wrote on Thu, Apr 05, 2012 at 14:05:31 -0400: > > On Apr 5, 2012 6:46 AM, "Philip Martin" wrote: > > > > > > > I've raised issue 4157 to track this problem. > > > > Can we at least implement a detection for this situation and fail

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-05 Thread Daniel Shahaf
Greg Stein wrote on Thu, Apr 05, 2012 at 14:05:31 -0400: > On Apr 5, 2012 6:46 AM, "Philip Martin" wrote: > > > > Branko Čibej writes: > > > > >> ... I think I may have identified the problem. The patch below checks > > >> that the error struct is allocated and released by the same thread. > > >

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-05 Thread Greg Stein
On Apr 5, 2012 6:46 AM, "Philip Martin" wrote: > > Branko Čibej writes: > > >> ... I think I may have identified the problem. The patch below checks > >> that the error struct is allocated and released by the same thread. > >> With the worker MPM the assertion always passes but with the event MP

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-05 Thread Philip Martin
Branko Čibej writes: >> ... I think I may have identified the problem. The patch below checks >> that the error struct is allocated and released by the same thread. >> With the worker MPM the assertion always passes but with the event MPM I >> get assertion failures. I don't fully understand th

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-04 Thread Branko Čibej
On 05.04.2012 00:44, Philip Martin wrote: > Philip Martin writes: > >> I think there is a refcount/locking bug in svn_fs_bdb__close. This code >> >> - if (0 == --bdb_baton->error_info->refcount && bdb->pool) >> -{ >> - svn_error_clear(bdb_baton->error_info->pending_errors); >> -#if APR_

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-04 Thread Philip Martin
Philip Martin writes: > I think there is a refcount/locking bug in svn_fs_bdb__close. This code > > - if (0 == --bdb_baton->error_info->refcount && bdb->pool) > -{ > - svn_error_clear(bdb_baton->error_info->pending_errors); > -#if APR_HAS_THREADS > - free(bdb_baton->error_info); >

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-04 Thread Philip Martin
Philip Martin writes: > ==10434== Thread 15: > ==10434== Invalid read of size 4 > ==10434==at 0x802D5BB: svn_fs_bdb__open_internal (env.c:660) > ==10434==by 0x802D679: svn_fs_bdb__open (env.c:672) > ==10434==by 0x80390D7: open_databases (fs.c:536) > ==10434==by 0x8039C26: base_ope

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-03 Thread Philip Martin
Philip Martin writes: > I'm not familiar with this code. I can "fix" the problem by removing > the free() from svn_fs_bdb__close but that's not really surprising given > the warnings above, nor is it a solution. The patch below also appears > to fix the problem but I'm reluctant to commit it un

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-03 Thread Philip Martin
Philip Martin writes: > ==10434== Thread 15: > ==10434== Invalid read of size 4 > ==10434==at 0x802D5BB: svn_fs_bdb__open_internal (env.c:660) > ==10434==by 0x802D679: svn_fs_bdb__open (env.c:672) > ==10434==by 0x80390D7: open_databases (fs.c:536) > ==10434==by 0x8039C26: base_ope

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-03 Thread Philip Martin
Branko Čibej writes: > On 02.04.2012 18:46, Philip Martin wrote: >> I am unable to run the Subversion regression tests for BDB and DAV with >> Apache 2.4 using the event MPM (the new default MPM in 2.4). Sometimes >> mod_dav_svn SEGVs causing tests to FAIL and sometimes the tests hang >> with mo

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-02 Thread Daniel Shahaf
Branko Čibej wrote on Mon, Apr 02, 2012 at 21:04:36 +0200: > On 02.04.2012 18:46, Philip Martin wrote: > > I am unable to run the Subversion regression tests for BDB and DAV with > > Apache 2.4 using the event MPM (the new default MPM in 2.4). Sometimes > > mod_dav_svn SEGVs causing tests to FAIL

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-02 Thread Branko Čibej
On 02.04.2012 18:46, Philip Martin wrote: > I am unable to run the Subversion regression tests for BDB and DAV with > Apache 2.4 using the event MPM (the new default MPM in 2.4). Sometimes > mod_dav_svn SEGVs causing tests to FAIL and sometimes the tests hang > with mod_dav_svn spinning in a loop.

Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-02 Thread Philip Martin
I am unable to run the Subversion regression tests for BDB and DAV with Apache 2.4 using the event MPM (the new default MPM in 2.4). Sometimes mod_dav_svn SEGVs causing tests to FAIL and sometimes the tests hang with mod_dav_svn spinning in a loop. The problems go away when I switch to the worker