Re: Some x509 branch review points

2014-10-29 Thread Ben Reser
On 10/15/14 3:15 AM, Philip Martin wrote: > 1) > > In x509parse.c:x509_get_version: > > err = asn1_get_tag(p, end, &len, > ASN1_CONTEXT_SPECIFIC | ASN1_CONSTRUCTED | 0); > > Why the "| 0"? It doesn't do anything. The 0 is there to say that the context specific value is 0

Re: Some x509 branch review points

2014-10-16 Thread Stefan Sperling
On Wed, Oct 15, 2014 at 11:15:42AM +0100, Philip Martin wrote: > 1) > > In x509parse.c:x509_get_version: > > err = asn1_get_tag(p, end, &len, > ASN1_CONTEXT_SPECIFIC | ASN1_CONSTRUCTED | 0); > > Why the "| 0"? It doesn't do anything. Inherited from the original tropicssl

Some x509 branch review points

2014-10-15 Thread Philip Martin
1) In x509parse.c:x509_get_version: err = asn1_get_tag(p, end, &len, ASN1_CONTEXT_SPECIFIC | ASN1_CONSTRUCTED | 0); Why the "| 0"? It doesn't do anything. 2) In x509parse.c:x509_get_name: cur->next = apr_palloc(result_pool, sizeof(x509_name)); if (cur->next == NUL