Re: Review Request: svn.fs.FileDiff

2018-02-12 Thread Troy Curtis Jr
On Sun, Feb 11, 2018 at 4:33 PM Daniel Shahaf wrote: > Troy Curtis Jr wrote on Sun, 11 Feb 2018 16:10 +: > > I'm asking for comments because the actual diff output given when > > 'diffoptions' is None, is changed. > ... > > Thoughts? > > 1. We have two consumers of FileDiff in tools/. Check

verify-before-commit knob [was: Review Request: svn.fs.FileDiff]

2018-02-12 Thread Julian Foad
Daniel Shahaf wrote: 2. We might include the change in an alpha/beta release to give it more testing. (#2 applies to FSFS's new verify-before-commit knob, too.) I noticed a 'verify-before-commit' option is included in fsfs.conf nowadays, "enabled by default in debug builds". (On unix that's

Re: Review Request: svn.fs.FileDiff

2018-02-11 Thread Daniel Shahaf
Troy Curtis Jr wrote on Sun, 11 Feb 2018 16:10 +: > I'm asking for comments because the actual diff output given when > 'diffoptions' is None, is changed. ... > Thoughts? 1. We have two consumers of FileDiff in tools/. Check whether they are affected? 2. We might include the change in an a

Review Request: svn.fs.FileDiff

2018-02-11 Thread Troy Curtis Jr
In parallel to the other discussion on import order of svn.fs.FileDiff, I'd like some comments on the attached patch. Mostly, this is to address the failing tests on Windows [0], since there isn't a 'diff' executable necessarily available. The attached patch uses the internal Subversion diff impl