Re: Re-use connection for svn:externals

2010-02-16 Thread Justin Erenkrantz
On Tue, Feb 16, 2010 at 12:33 AM, Ivan Zhakov wrote: > You can do that only if you assume that connections from different > sessions should have same authentication, which is not true imho. If it's pointing to the same server, wouldn't it? How often is it that you would do *connection-level* aut

Re: Re-use connection for svn:externals

2010-02-16 Thread Ivan Zhakov
On Tue, Feb 16, 2010 at 10:10 AM, Justin Erenkrantz wrote: > On Mon, Feb 15, 2010 at 10:18 PM, Phillip Hellewell wrote: >> Alright.  Here are my thoughts so far based on what others have said: >> >> I'm not quite sure about Justin's suggestion, because I don't think the >> delay is in establishin

Re: Re-use connection for svn:externals

2010-02-15 Thread Justin Erenkrantz
On Mon, Feb 15, 2010 at 10:18 PM, Phillip Hellewell wrote: > Alright.  Here are my thoughts so far based on what others have said: > > I'm not quite sure about Justin's suggestion, because I don't think the > delay is in establishing the TCP connection; I think it is in performing the > authentica

Re: Re-use connection for svn:externals

2010-02-15 Thread Ivan Zhakov
On Tue, Feb 16, 2010 at 9:18 AM, Phillip Hellewell wrote: > Alright.  Here are my thoughts so far based on what others have said: > > I'm not quite sure about Justin's suggestion, because I don't think the > delay is in establishing the TCP connection; I think it is in performing the > authenticat

Re: Re-use connection for svn:externals

2010-02-15 Thread Phillip Hellewell
Alright. Here are my thoughts so far based on what others have said: I'm not quite sure about Justin's suggestion, because I don't think the delay is in establishing the TCP connection; I think it is in performing the authentication and stuff. So just re-using a TCP connection won't buy us much,

Re: Re-use connection for svn:externals

2010-02-15 Thread Julian Foad
On Tue, 2010-02-09, Phillip Hellewell wrote: > On Tue, Feb 9, 2010 at 10:09 AM, Julian Foad wrote: > > > > > Would you, or anyone you know, be interested in working on it? I would > > be glad to give you some help and guidance. > > > > I don't have any experience with the subversion source code r

Re: Re-use connection for svn:externals

2010-02-10 Thread kmradke
Phillip Hellewell wrote on 02/10/2010 09:11:40 AM: > > The '3 seconds delay' is most likely caused by the slow opening of HTTP > > sessions which walk up the repository to find the repository root.This case > > is already fixed in HTTPv2. (svn:// is much faster than this. And svn+ssh:// > > dep

Re: Re-use connection for svn:externals

2010-02-10 Thread Justin Erenkrantz
On Wed, Feb 10, 2010 at 2:07 AM, Bert Huijben wrote: > This thread suggests using full urls everywhere. And the thread closes with > the reasoning that this will cause all kinds of new security issues as we > have to do the url encoding everywhere. (Encoding one time more than required > or one

Re: Re-use connection for svn:externals

2010-02-10 Thread C. Michael Pilato
Phillip Hellewell wrote: > On Wed, Feb 10, 2010 at 3:07 AM, Bert Huijben > wrote: > > > The '3 seconds delay' is most likely caused by the slow opening of > HTTP sessions which walk up the repository to find the repository > root. This case is already fixed in

Re: Re-use connection for svn:externals

2010-02-10 Thread Phillip Hellewell
On Wed, Feb 10, 2010 at 3:07 AM, Bert Huijben wrote: > > The '3 seconds delay' is most likely caused by the slow opening of HTTP > sessions which walk up the repository to find the repository root. This case > is already fixed in HTTPv2. (svn:// is much faster than this. And svn+ssh:// > depends

RE: Re-use connection for svn:externals

2010-02-10 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julian.f...@wandisco.com] > Sent: woensdag 10 februari 2010 0:06 > To: Stefan Sperling > Cc: Bert Huijben; Ivan Zhakov; C. Michael Pilato; Phillip Hellewell; > dev@subversion.apache.org > Subject: Re: Re-use connect

Re: Re-use connection for svn:externals

2010-02-09 Thread Julian Foad
On Tue, 2010-02-09, Stefan Sperling wrote: > On Tue, Feb 09, 2010 at 08:19:07PM +0100, Bert Huijben wrote: > > > Van: Ivan Zhakov > > > The only problem I see is RA session root relative paths [1], since we > > > end up with pool of connection for one repository but with different > > > session roo

Re: Re-use connection for svn:externals

2010-02-09 Thread Phillip Hellewell
On Tue, Feb 9, 2010 at 10:09 AM, Julian Foad wrote: > > Would you, or anyone you know, be interested in working on it? I would > be glad to give you some help and guidance. > I don't have any experience with the subversion source code right now, but I'd be willing to become familiar with it if no

Re: Re-use connection for svn:externals

2010-02-09 Thread Ivan Zhakov
On Tue, Feb 9, 2010 at 9:19 PM, Bert Huijben wrote: > Opening at repository root reintroduces issue #3242 (Authorization fails at > repository root) > Sure, I'm aware about issue #3242. My proposal is to open RA session using some expected to be readable URL and then reparenting it to repository

Re: Re-use connection for svn:externals

2010-02-09 Thread Stefan Sperling
On Tue, Feb 09, 2010 at 08:19:07PM +0100, Bert Huijben wrote: > > Van: Ivan Zhakov > > The only problem I see is RA session root relative paths [1], since we > > end up with pool of connection for one repository but with different > > session root. We may workaround it using convention that svn_cli

RE: Re-use connection for svn:externals

2010-02-09 Thread Bert Huijben
: Re-use connection for svn:externals On Tue, Feb 9, 2010 at 7:51 PM, C. Michael Pilato wrote: > Ivan Zhakov wrote: >> On Tue, Feb 9, 2010 at 7:09 PM, Julian Foad wrote: >>> There are several places where the client should/could re-use a >>> connection. During a multi

Re: Re-use connection for svn:externals

2010-02-09 Thread Ivan Zhakov
On Tue, Feb 9, 2010 at 7:51 PM, C. Michael Pilato wrote: > Ivan Zhakov wrote: >> On Tue, Feb 9, 2010 at 7:09 PM, Julian Foad wrote: >>> There are several places where the client should/could re-use a >>> connection. During a multi-target update command like "svn up a b c" is >>> another example.

Re: Re-use connection for svn:externals

2010-02-09 Thread C. Michael Pilato
Ivan Zhakov wrote: > On Tue, Feb 9, 2010 at 7:09 PM, Julian Foad wrote: >> There are several places where the client should/could re-use a >> connection. During a multi-target update command like "svn up a b c" is >> another example. >> >> Would you, or anyone you know, be interested in working on

Re: Re-use connection for svn:externals

2010-02-09 Thread Ivan Zhakov
On Tue, Feb 9, 2010 at 7:09 PM, Julian Foad wrote: > On Mon, 2010-02-08, Phillip Hellewell wrote: >> I'm not sure if this is related to issue 1448 or not (it's kinda like the >> opposite of 1448 actually), but I use externals extensively and doing an >> update is slow.  It appears to be creating a

Re: Re-use connection for svn:externals

2010-02-09 Thread Julian Foad
On Mon, 2010-02-08, Phillip Hellewell wrote: > I'm not sure if this is related to issue 1448 or not (it's kinda like the > opposite of 1448 actually), but I use externals extensively and doing an > update is slow. It appears to be creating a new connection for each > external even though it's the

Re-use connection for svn:externals

2010-02-08 Thread Phillip Hellewell
Hi, I'm not sure if this is related to issue 1448 or not (it's kinda like the opposite of 1448 actually), but I use externals extensively and doing an update is slow. It appears to be creating a new connection for each external even though it's the same repository on the same server. Each connec