Re: useful extra check in FS fold_change function

2010-03-22 Thread David Glasser
On Mon, Mar 22, 2010 at 9:46 AM, C. Michael Pilato wrote: > C. Michael Pilato wrote: >> David Glasser wrote: Is the attached patch what you had in mind?  (Plus similar logic for FSFS, of course.) >>> Ah, yes, that's what I meant; that patch looks great, assuming it >>> works :) >> >> I'l

Re: useful extra check in FS fold_change function

2010-03-22 Thread C. Michael Pilato
Blair Zajac wrote: > On 03/22/2010 09:46 AM, C. Michael Pilato wrote: >> C. Michael Pilato wrote: >>> David Glasser wrote: > Is the attached patch what you had in mind? (Plus similar logic > for FSFS, > of course.) Ah, yes, that's what I meant; that patch looks great, assuming it

Re: useful extra check in FS fold_change function

2010-03-22 Thread Blair Zajac
On 03/22/2010 12:56 PM, Hyrum K. Wright wrote: On Mar 22, 2010, at 1:41 PM, Blair Zajac wrote: My name isn't David, but I now have 50+ repositories with 8.7 million revisions between them exposed via a Thrift-like API of svn_fs that anybody can modify the filesystem in any order, so it if a

Re: useful extra check in FS fold_change function

2010-03-22 Thread Hyrum K. Wright
On Mar 22, 2010, at 1:41 PM, Blair Zajac wrote: > My name isn't David, but I now have 50+ repositories with 8.7 million > revisions between them exposed via a Thrift-like API of svn_fs that anybody > can modify the filesystem in any order, so it if a user could make a > particular set of modif

Re: useful extra check in FS fold_change function

2010-03-22 Thread Blair Zajac
On 03/22/2010 09:46 AM, C. Michael Pilato wrote: C. Michael Pilato wrote: David Glasser wrote: Is the attached patch what you had in mind? (Plus similar logic for FSFS, of course.) Ah, yes, that's what I meant; that patch looks great, assuming it works :) I'll try to polish this up, add the

Re: useful extra check in FS fold_change function

2010-03-22 Thread C. Michael Pilato
C. Michael Pilato wrote: > David Glasser wrote: >>> Is the attached patch what you had in mind? (Plus similar logic for FSFS, >>> of course.) >> Ah, yes, that's what I meant; that patch looks great, assuming it >> works :) > > I'll try to polish this up, add the FSFS flavor, and add a regression

Re: useful extra check in FS fold_change function

2010-03-20 Thread Stefan Sperling
On Fri, Mar 19, 2010 at 06:04:45PM -0700, David Glasser wrote: > I would like to get a working Subversion development > environment back one of these days, once I re-derive how to work > around the Debian libtool issue again... Compile your own APR libs from source, and svn will use APR's libtool.

Re: useful extra check in FS fold_change function

2010-03-19 Thread C. Michael Pilato
David Glasser wrote: >> Is the attached patch what you had in mind? (Plus similar logic for FSFS, >> of course.) > > Ah, yes, that's what I meant; that patch looks great, assuming it > works :) I'll try to polish this up, add the FSFS flavor, and add a regression test when I get some time. Than

Re: useful extra check in FS fold_change function

2010-03-19 Thread David Glasser
On Fri, Mar 19, 2010 at 10:26 AM, C. Michael Pilato wrote: > David Glasser wrote: >> When dealing with some nasty cases in the almost-retired old Google >> Code subversion backend, I found a kind of data corruption that the FS >> code wasn't catching even though it caught relatively similar issues

Re: useful extra check in FS fold_change function

2010-03-19 Thread C. Michael Pilato
David Glasser wrote: > When dealing with some nasty cases in the almost-retired old Google > Code subversion backend, I found a kind of data corruption that the FS > code wasn't catching even though it caught relatively similar issues. > Specifically, find the fold_change function in both of the FS