Re: svnadmin verify + rep-cache.db

2011-07-13 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, Jul 13, 2011 at 15:59:36 +0200: > Hi all, > > while repairing some bad repository breakage we noticed that > svnadmin verify does not check whether offsets mentioned in > rep-cache.db point to valid reps. > > In some cases I had to append repaired reps after the chan

Re: svnadmin verify + rep-cache.db

2011-07-13 Thread Peter Samuelson
[Stefan Sperling] > So now 'svnadmin verify' runs fine. But when the rep-cache is > referred to during commit we can still run into reps that are broken. > > Obviously we'll either have to fix up the rep-cache as well, > or simply delete it. But the point is that 'svnadmin verify' > does not comp

Re: svnadmin verify + rep-cache.db

2011-07-13 Thread Daniel Shahaf
Daniel Shahaf wrote on Wed, Jul 13, 2011 at 17:11:34 +0300: > Stefan Sperling wrote on Wed, Jul 13, 2011 at 15:59:36 +0200: > > while repairing some bad repository breakage we noticed that > > svnadmin verify does not check whether offsets mentioned in > > rep-cache.db point to valid reps. > > Doe

Re: svnadmin verify + rep-cache.db

2011-07-13 Thread Daniel Shahaf
Does implementing this require API changes? (extending the fs-loader.h vtables) There is currently no svn_fs_verify() API. Stefan Sperling wrote on Wed, Jul 13, 2011 at 15:59:36 +0200: > Hi all, > > while repairing some bad repository breakage we noticed that > svnadmin verify does not check w

Re: svnadmin verify + rep-cache.db

2011-07-13 Thread Daniel Shahaf
+1; we already validate reps given in node-revision headers. (could you CC me on the issue?) Stefan Sperling wrote on Wed, Jul 13, 2011 at 15:59:36 +0200: > Hi all, > > while repairing some bad repository breakage we noticed that > svnadmin verify does not check whether offsets mentioned in > re