Re: svn status tabbed output [was: Re: svn status should not show unmodified files in changelists]

2019-11-08 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, 07 Nov 2019 17:15 +00:00: > +++ subversion/tests/cmdline/info_tests.py(working copy) > @@ -644,6 +644,10 @@ def info_item_simple(sbox): > + svntest.actions.run_and_verify_svn( > +['1\tdir'], [], > +'info', '--show-item=revision,kind', '--no-newline', > +

Re: svn status should not show unmodified files in changelists

2019-11-08 Thread Branko Čibej
On 08.11.2019 10:48, Daniel Shahaf wrote: > Nathan Hartman wrote on Fri, Nov 08, 2019 at 00:58:29 -0500: >> In my mind, listing changelists (and which files are "in" them) should >> be a documented part of the changelist feature, not something achieved >> by a non-obvious invocation of 'svn status'

Re: svn status should not show unmodified files in changelists

2019-11-08 Thread Nathan Hartman
On Fri, Nov 8, 2019 at 8:00 AM Julian Foad wrote: > Nathan Hartman wrote: > > > Friday% svn st -q > > > --- Changelist 'foo': > > > M iota > > > Friday% vi A/mu > > > Friday% svn commit -mm --cl foo > > > Sendingiota > > > SendingA/mu > > > # ... "Revert accidental c

Re: svn status should not show unmodified files in changelists

2019-11-08 Thread Julian Foad
Daniel Shahaf wrote: The intended reading of the example is [...] I know, but we're not going to get much further by focusing on that example. I wonder if we should invent some notion of "quiet" changelist, [...] A quality of being "quiet in the context of svn-status" is not a good quality

Re: svn status should not show unmodified files in changelists

2019-11-08 Thread Daniel Shahaf
Julian Foad wrote on Fri, 08 Nov 2019 13:00 +00:00: > Nathan Hartman wrote: > > > Friday% svn st -q > > > --- Changelist 'foo': > > > M       iota > > > Friday% vi A/mu > > > Friday% svn commit -mm --cl foo > > > Sending        iota > > > Sending        A/mu > > > # ... "Revert accidental c

Re: svn status should not show unmodified files in changelists

2019-11-08 Thread Julian Foad
Nathan Hartman wrote: > Friday% svn st -q > --- Changelist 'foo': > M       iota > Friday% vi A/mu > Friday% svn commit -mm --cl foo > Sending        iota > Sending        A/mu > # ... "Revert accidental commit" You're right. That would be immensely irritating... The opposite reading o

Re: svn status should not show unmodified files in changelists

2019-11-08 Thread Nathan Hartman
On Fri, Nov 8, 2019 at 4:48 AM Daniel Shahaf wrote: Nathan Hartman wrote on Fri, Nov 08, 2019 at 00:58:29 -0500: >> Daniel suggested to leave the behavior of 'svn status' as-is, unless >> 'svn status' is run with both -v and -q. > > That's not what I suggested. I misunderstood... sorry! More belo

Re: svn status should not show unmodified files in changelists

2019-11-08 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, Nov 08, 2019 at 00:58:29 -0500: > Daniel suggested to leave the behavior of 'svn status' as-is, unless > 'svn status' is run with both -v and -q. That's not what I suggested. I suggested to modify the behaviour if -q is passed, *regardless* of whether -v is passed or

Re: svn status should not show unmodified files in changelists

2019-11-07 Thread Nathan Hartman
On Thu, Nov 7, 2019 at 6:13 AM Daniel Shahaf wrote: > 2. As Nathan said, this can make it difficult to answer "Which unmodified > files > are in a changelist?". (Yes, it's still possible to answer this by parsing > the output of «svn info», but that's far from elegant, particularly since > it's

Re: svn status tabbed output [was: Re: svn status should not show unmodified files in changelists]

2019-11-07 Thread Julian Foad
Branko Čibej wrote: We might want to allow using multiple options, like "--show-item=revision --show-item=kind" in addition to comma-separated values. I don't think this is high priority. *And* it would require a major rewrite of our argument parser, whereas adding a comma-separated list forma

Re: svn status tabbed output [was: Re: svn status should not show unmodified files in changelists]

2019-11-07 Thread Daniel Shahaf
Branko Čibej wrote on Thu, 07 Nov 2019 20:01 +00:00: > On 07.11.2019 20:25, Daniel Shahaf wrote: > >> We might want to allow using multiple options, like "--show-item=revision > >> --show-item=kind" in addition to comma-separated values. > > I don't think this is high priority. > > *And* it would

Re: svn status tabbed output [was: Re: svn status should not show unmodified files in changelists]

2019-11-07 Thread Julian Foad
Daniel Shahaf wrote: [...]> I don't see how any of these visions — leaving aside whether they're good ideas or not — is a blocker to the patch I posted. You're saying we could add other features, and I'm sure we could, but that's not the right question to ask. The question to ask is whether th

Re: svn status tabbed output [was: Re: svn status should not show unmodified files in changelists]

2019-11-07 Thread Branko Čibej
On 07.11.2019 20:25, Daniel Shahaf wrote: > Julian Foad wrote on Thu, Nov 07, 2019 at 17:53:43 +: > We would then have «svn info --rfc822 > --show-item=depth» that prints "Depth: empty" (with the RFC822 header) Nitpick: it's not really RFC822 because there are spaces in the "headers" ... [...

Re: svn status tabbed output [was: Re: svn status should not show unmodified files in changelists]

2019-11-07 Thread Daniel Shahaf
Julian Foad wrote on Thu, Nov 07, 2019 at 17:53:43 +: > We have said the outputs (except XML) simply are not intended to be parsed. We've said that? I think what we said is that the non-XML outputs _may_ be parsed, but with care, since they may change in minor releases as functionality gets a

Re: svn status tabbed output [was: Re: svn status should not show unmodified files in changelists]

2019-11-07 Thread Julian Foad
Daniel Shahaf wrote: Branko Čibej wrote on Thu, Nov 07, 2019 at 17:28:35 +0100: Not with a new option. Instead --show-item should accept a comma-separated list of keywords. You mean, like this? It's tempting to say +1, commit it, and say we've made an improvement. I have been missing the ab

Re: svn status tabbed output [was: Re: svn status should not show unmodified files in changelists]

2019-11-07 Thread Daniel Shahaf
Branko Čibej wrote on Thu, Nov 07, 2019 at 17:28:35 +0100: > Not with a new option. Instead --show-item should accept a > comma-separated list of keywords. You mean, like this? [[[ % subversion/svn/svn info wc/foo --show-item=kind,schedule,relative-url dir add ^/foo % ]]] That's not a

svn status tabbed output [was: Re: svn status should not show unmodified files in changelists]

2019-11-07 Thread Branko Čibej
On 07.11.2019 12:13, Daniel Shahaf wrote: > P.S. Come to think of it, a tab-separated output mode for «svn info» might be > nice; that is, instead of this: > . > % svn info README > Path: README > Name: README > Working Copy Root Path: /home/daniel/src/svn/t1 > URL: https://svn

Re: svn status should not show unmodified files in changelists

2019-11-07 Thread Julian Foad
Daniel Shahaf wrote: Julian Foad wrote on Wed, Nov 06, 2019 at 16:07:23 +: Perhaps one aspect of being in a mature and stable phase of a project's life means that if we are going to change how an existing feature works, we should not change it one little bit at a time like we did in early de

Re: svn status should not show unmodified files in changelists

2019-11-07 Thread Daniel Shahaf
Julian Foad wrote on Wed, Nov 06, 2019 at 16:07:23 +: > Perhaps one aspect of being in a mature and stable phase of a project's life > means that if we are going to change how an existing feature works, we > should not change it one little bit at a time like we did in early > development phases

Re: svn status should not show unmodified files in changelists

2019-11-07 Thread Daniel Shahaf
Julian Foad wrote on Wed, Nov 06, 2019 at 10:36:10 +: > Demo: > [[[ > $ touch a b c d; svn add a b c d; svn ci -m ""; svn up > ... > $ echo hello > b > $ echo hello > d > $ svn cl foo c d > A [foo] c > A [foo] d > $ svn status -v > 11 julianfoad . > 1

Re: svn status should not show unmodified files in changelists

2019-11-06 Thread Julian Foad
Nathan Hartman wrote: "svn status" (without -v) is defined as showing only locally modified items. So I wouldn't object to that, provided there's a way to list changelist(s) in effect and what files are in them. Well, "svn status -v" would still show them, but I agree with your point in genera

Re: svn status should not show unmodified files in changelists

2019-11-06 Thread Nathan Hartman
On Wed, Nov 6, 2019 at 5:36 AM Julian Foad wrote: > svn status doesn't generally show unmodified files, except with '-v'. > However, in changelists, it shows unmodified files, even without '-v' > I am finding this to be a inconsistent, and a nuisance because I am > currently working on a task i