Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-20 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Mon, Sep 20, 2010 at 10:35:34 +0530: > Hi Daniel, > > Daniel Shahaf writes: > > Ramkumar Ramachandra wrote on Sun, Sep 19, 2010 at 16:52:50 +0530: > > > Daniel Shahaf writes: > > > > Stefan Sperling wrote on Sun, Sep 19, 2010 at 11:40:49 +0200: > > > > > On Sun, Sep 1

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-19 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > Ramkumar Ramachandra wrote on Sun, Sep 19, 2010 at 16:52:50 +0530: > > Daniel Shahaf writes: > > > Stefan Sperling wrote on Sun, Sep 19, 2010 at 11:40:49 +0200: > > > > On Sun, Sep 19, 2010 at 10:29:58AM +0100, Daniel Shahaf wrote: > > > > > 2. If you do duplicat

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-19 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Sun, Sep 19, 2010 at 16:52:50 +0530: > Daniel Shahaf writes: > > Stefan Sperling wrote on Sun, Sep 19, 2010 at 11:40:49 +0200: > > > On Sun, Sep 19, 2010 at 10:29:58AM +0100, Daniel Shahaf wrote: > > > > 2. If you do duplicate code, then add big comments (in all instan

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-19 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > artag...@apache.org wrote on Sat, Sep 18, 2010 at 17:54:50 -: > > +#define SVNRDUMP_PROP_LOCK "rdump-lock" > > Need SVN_PROP_PREFIX. Fixed in r998772. > 1. Please don't duplicate code. > > 2. If you do duplicate code, then add big comments (in all instanc

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-19 Thread Ramkumar Ramachandra
Hi, Daniel Shahaf writes: > Stefan Sperling wrote on Sun, Sep 19, 2010 at 11:40:49 +0200: > > On Sun, Sep 19, 2010 at 10:29:58AM +0100, Daniel Shahaf wrote: > > > 1. Please don't duplicate code. > > > > I think it's fine for svnrdump to have its own copy of this for now. > > We could at some poin

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-19 Thread Daniel Shahaf
Stefan Sperling wrote on Sun, Sep 19, 2010 at 11:40:49 +0200: > On Sun, Sep 19, 2010 at 10:29:58AM +0100, Daniel Shahaf wrote: > > artag...@apache.org wrote on Sat, Sep 18, 2010 at 17:54:50 -: > > > +static svn_error_t * > > > +get_lock(svn_ra_session_t *session, apr_pool_t *pool) > > > +{ ...

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-19 Thread Stefan Sperling
On Sun, Sep 19, 2010 at 10:29:58AM +0100, Daniel Shahaf wrote: > artag...@apache.org wrote on Sat, Sep 18, 2010 at 17:54:50 -: > > Author: artagnon > > Date: Sat Sep 18 17:54:50 2010 > > New Revision: 998502 > > > > URL: http://svn.apache.org/viewvc?rev=998502&view=rev > > Log: > > * subversio

Re: svn commit: r998502 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-09-19 Thread Daniel Shahaf
artag...@apache.org wrote on Sat, Sep 18, 2010 at 17:54:50 -: > Author: artagnon > Date: Sat Sep 18 17:54:50 2010 > New Revision: 998502 > > URL: http://svn.apache.org/viewvc?rev=998502&view=rev > Log: > * subversion/svnrdump/load_editor.c: Attempt to acquire a lock of > sorts before attempt