Re: svn commit: r964729 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-07-16 Thread Philip Martin
Greg Stein writes: > This is just scattering them around, rather than thinking about where > they should go. > > Basically, reset as soon as possible after pulling column values. That > means after the assignment of "levels", where column_int() is called, > and then in an else branch of the got_r

Re: svn commit: r964729 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2010-07-16 Thread Greg Stein
This is just scattering them around, rather than thinking about where they should go. Basically, reset as soon as possible after pulling column values. That means after the assignment of "levels", where column_int() is called, and then in an else branch of the got_row test. Thus, a reset isn't ne