Re: svn commit: r922511 - /subversion/trunk/subversion/libsvn_client/commit.c

2010-03-18 Thread Philip Martin
Greg Stein writes: >> @@ -1040,13 +1046,10 @@ check_nonrecursive_dir_delete(void *bato >>   */ >>   if (btn->depth != svn_depth_infinity) >>     { >> -      svn_wc_status2_t *status; >> -      svn_node_kind_t kind; >> - >> -      SVN_ERR(svn_io_check_path(target_abspath, &kind, pool)); > > ... lo

Re: svn commit: r922511 - /subversion/trunk/subversion/libsvn_client/commit.c

2010-03-18 Thread Greg Stein
On Sat, Mar 13, 2010 at 05:27, wrote: >... > +++ subversion/trunk/subversion/libsvn_client/commit.c Sat Mar 13 09:27:20 > 2010 >... > @@ -1010,17 +1009,24 @@ static svn_error_t * >  check_nonrecursive_dir_delete(void *baton, void *this_item, apr_pool_t *pool) >  { >   struct check_dir_delete_bat

Re: svn commit: r922511 - /subversion/trunk/subversion/libsvn_client/commit.c

2010-03-14 Thread Philip Martin
"Bert Huijben" writes: > http://buildbot.subversion.org/buildbot/waterfall still says that the svn x > fsfs build testsuite is broken. > (This buildbot uses a recent trunk for checking out the build working > copy... that could make a difference for the specific test) $ cd subversion/tests/cmdli

RE: svn commit: r922511 - /subversion/trunk/subversion/libsvn_client/commit.c

2010-03-14 Thread Bert Huijben
> -Original Message- > From: Philip Martin [mailto:philip.mar...@wandisco.com] > Sent: zondag 14 maart 2010 19:10 > To: Bert Huijben > Cc: dev@subversion.apache.org; phi...@apache.org > Subject: Re: svn commit: r922511 - > /subversion/trunk/subversion/libsvn_clien

Re: svn commit: r922511 - /subversion/trunk/subversion/libsvn_client/commit.c

2010-03-14 Thread Philip Martin
"Bert Huijben" writes: >> New Revision: 922511 >> >> URL: http://svn.apache.org/viewvc?rev=922511&view=rev >> Log: >> Remove access batons from client commit code. >> >> * subversion/libsvn_client/commit.c >> (struct check_dir_delete_baton): Remove access baton. >> (check_nonrecursive_dir_d

RE: svn commit: r922511 - /subversion/trunk/subversion/libsvn_client/commit.c

2010-03-14 Thread Bert Huijben
> -Original Message- > From: phi...@apache.org [mailto:phi...@apache.org] > Sent: zaterdag 13 maart 2010 10:27 > To: comm...@subversion.apache.org > Subject: svn commit: r922511 - > /subversion/trunk/subversion/libsvn_client/commit.c > > Author: philip > Date: Sat Mar 13 09:27:20 2010 >

Re: svn commit: r922511 - /subversion/trunk/subversion/libsvn_client/commit.c

2010-03-14 Thread Philip Martin
Greg Stein writes: > Rather than explicit acquire/release, I think we're trying to use > svn_wc__call_with_write_lock(). That will ensure that we don't leave > write locks around on an error exit. I've used svn_wc__call_with_write_lock in the past but I feel that the baton interface is cumbersom

Re: svn commit: r922511 - /subversion/trunk/subversion/libsvn_client/commit.c

2010-03-13 Thread Greg Stein
On Sat, Mar 13, 2010 at 04:27, wrote: > Author: philip > Date: Sat Mar 13 09:27:20 2010 > New Revision: 922511 > > URL: http://svn.apache.org/viewvc?rev=922511&view=rev > Log: > Remove access batons from client commit code. > > * subversion/libsvn_client/commit.c >  (struct check_dir_delete_baton