On Mon, 2010-03-29 at 19:42 +0200, Stefan Küng wrote:
> On 29.03.2010 15:08, Julian Foad wrote:
> > On Sat, 2010-03-27, Stefan Küng wrote:
> >> On 27.03.2010 15:23, Stefan Sperling wrote:
> >>> On Fri, Mar 26, 2010 at 07:57:09PM +0100, Stefan Küng wrote:
> On 26.03.2010 18:17, Stefan Sperling
On 29.03.2010 15:08, Julian Foad wrote:
On Sat, 2010-03-27, Stefan Küng wrote:
On 27.03.2010 15:23, Stefan Sperling wrote:
On Fri, Mar 26, 2010 at 07:57:09PM +0100, Stefan Küng wrote:
On 26.03.2010 18:17, Stefan Sperling wrote:
Can you check if the current API matches your requirements?
See s
On Sat, 2010-03-27, Stefan Küng wrote:
> On 27.03.2010 15:23, Stefan Sperling wrote:
> > On Fri, Mar 26, 2010 at 07:57:09PM +0100, Stefan Küng wrote:
> >> On 26.03.2010 18:17, Stefan Sperling wrote:
> >>> Can you check if the current API matches your requirements?
> >>> See subversion/tests/libsvn_
On 27.03.2010 15:23, Stefan Sperling wrote:
On Fri, Mar 26, 2010 at 07:57:09PM +0100, Stefan Küng wrote:
On 26.03.2010 18:17, Stefan Sperling wrote:
Can you check if the current API matches your requirements?
See subversion/tests/libsvn_client/client-test.c for a trivial example.
Looks very g
On Fri, Mar 26, 2010 at 07:57:09PM +0100, Stefan Küng wrote:
> On 26.03.2010 18:17, Stefan Sperling wrote:
> >Can you check if the current API matches your requirements?
> >See subversion/tests/libsvn_client/client-test.c for a trivial example.
>
> Looks very good! Thanks a lot for implementing th
On 26.03.2010 18:17, Stefan Sperling wrote:
On Wed, Mar 10, 2010 at 06:56:12PM +0100, Stefan Küng wrote:
And it would be great if I could tell where to save the result, i.e.
not having the patch applied to the target file but to a copy of
that file instead so I can show the user a preview of the
On Wed, Mar 10, 2010 at 06:56:12PM +0100, Stefan Küng wrote:
> And it would be great if I could tell where to save the result, i.e.
> not having the patch applied to the target file but to a copy of
> that file instead so I can show the user a preview of the result
> without actually modifying the
On Sat, Mar 13, 2010 at 09:41:06AM +0100, Stefan Sperling wrote:
> On Fri, Mar 12, 2010 at 11:12:38PM -0800, Joe Swatosh wrote:
> > On Fri, Mar 12, 2010 at 1:45 AM, Stefan Sperling wrote:
> > > On Fri, Mar 12, 2010 at 03:11:06AM +0100, Neels J Hofmeyr wrote:
> > >> Stefan Sperling wrote:
> > >> >>
On Sat, Mar 13, 2010 at 12:41 AM, Stefan Sperling wrote:
> On Fri, Mar 12, 2010 at 11:12:38PM -0800, Joe Swatosh wrote:
>
> I also highly appreciate Stefan K's feedback. Even though in this thread
> it may have seemed like I was primarily arguing against his points,
> the point of doing so is not
On Fri, Mar 12, 2010 at 11:12:38PM -0800, Joe Swatosh wrote:
> On Fri, Mar 12, 2010 at 1:45 AM, Stefan Sperling wrote:
> > On Fri, Mar 12, 2010 at 03:11:06AM +0100, Neels J Hofmeyr wrote:
> >> Stefan Sperling wrote:
> >> >>> What is not possible (without adding the --include-pattern option)
>
> >
On Fri, Mar 12, 2010 at 1:45 AM, Stefan Sperling wrote:
> On Fri, Mar 12, 2010 at 03:11:06AM +0100, Neels J Hofmeyr wrote:
>> Stefan Sperling wrote:
>> >>> What is not possible (without adding the --include-pattern option)
>
> It does. You can manually revert the edits 'svn patch' made to the fil
On 12.03.2010 10:45, Stefan Sperling wrote:
On Fri, Mar 12, 2010 at 03:11:06AM +0100, Neels J Hofmeyr wrote:
Stefan Sperling wrote:
What is not possible (without adding the --include-pattern option)
is selecting which files to patch. Is selecting individual patch
targets really that important?
On 12.03.2010 10:34, Stefan Sperling wrote:
Fine. Either way would work for me.
But who is responsible for cleaning up the temporary files?
The caller of svn_client_patch() or a pool cleanup handler installed
by svn_client_patch() at the result_pool provided by the caller?
In that case, the ca
On 11.03.2010 23:44, Stefan Sperling wrote:
On Thu, Mar 11, 2010 at 07:07:04PM +0100, Stefan Küng wrote:
On 10.03.2010 23:22, Stefan Sperling wrote:
svn_error_t *
svn_client_patch(const char *abs_patch_path,
const char *local_abspath,
svn_boolean_t dry_run,
Stefan Sperling wrote:
> On Fri, Mar 12, 2010 at 03:11:06AM +0100, Neels J Hofmeyr wrote:
[...]
> > So anything it does with patches should be done by
> > svn. In effect, whatever Tortoise wants to do with a patch has to be
> > implemented in svn, taking away dev time from wc-ng, pristine store and
On Fri, Mar 12, 2010 at 03:11:06AM +0100, Neels J Hofmeyr wrote:
> Stefan Sperling wrote:
> >>> What is not possible (without adding the --include-pattern option)
> >>> is selecting which files to patch. Is selecting individual patch
> >>> targets really that important?
> >> Yes, that's very import
On Fri, Mar 12, 2010 at 12:05:48AM +, Julian Foad wrote:
> Stefan Sperling wrote:
> > Right now, the tempfiles will be closed on pool cleanup.
>
> You mean "will be deleted on pool cleanup"?
Yes.
>
> > My idea was to specify svn_io_file_del_on_close instead in case
> > tempfiles is not NULL.
Stefan Sperling wrote:
>>> What is not possible (without adding the --include-pattern option)
>>> is selecting which files to patch. Is selecting individual patch
>>> targets really that important?
>> Yes, that's very important. I often find that when I get a patch, I
>> only want to use part of it
Julian Foad wrote:
> To be frank, I am heartily looking forward to the day when we can have
> your expertise focused back on tree conflicts, WC-NG, merging or such
> like.
Yeah, stsp, what's up with that! ;)
~Neels
signature.asc
Description: OpenPGP digital signature
Stefan Sperling wrote:
> On Thu, Mar 11, 2010 at 07:07:04PM +0100, Stefan Küng wrote:
> > On 10.03.2010 23:22, Stefan Sperling wrote:
> > >svn_error_t *
> > >svn_client_patch(const char *abs_patch_path,
> > > const char *local_abspath,
> > > svn_boolean_t dry_run,
On Thu, Mar 11, 2010 at 07:07:04PM +0100, Stefan Küng wrote:
> On 10.03.2010 23:22, Stefan Sperling wrote:
> >svn_error_t *
> >svn_client_patch(const char *abs_patch_path,
> > const char *local_abspath,
> > svn_boolean_t dry_run,
> > int strip_coun
On 10.03.2010 23:22, Stefan Sperling wrote:
Reviewing a patch file is not what most users expect and are
familiar with. Especially if there are many changes spread through a
big file, it's not enough to just see the patch file with the three
context lines to really get what the changes do - you
On Wed, Mar 10, 2010 at 10:50:13PM +0100, Stefan Küng wrote:
> On 10.03.2010 22:43, Stefan Sperling wrote:
> >On Wed, Mar 10, 2010 at 08:58:24PM +0100, Stefan Küng wrote:
> >>On 10.03.2010 19:14, Julian Foad wrote:
> >>
> Yes, I would also need to know which paths the patch wants to modify,
> >
On 10.03.2010 22:43, Stefan Sperling wrote:
On Wed, Mar 10, 2010 at 08:58:24PM +0100, Stefan Küng wrote:
On 10.03.2010 19:14, Julian Foad wrote:
Yes, I would also need to know which paths the patch wants to modify,
and then later I want to tell the API which of those paths it should
actually m
On Wed, Mar 10, 2010 at 08:58:24PM +0100, Stefan Küng wrote:
> On 10.03.2010 19:14, Julian Foad wrote:
>
> >>Yes, I would also need to know which paths the patch wants to modify,
> >>and then later I want to tell the API which of those paths it should
> >>actually modify.
> >>This is to let the us
On 10.03.2010 19:14, Julian Foad wrote:
Yes, I would also need to know which paths the patch wants to modify,
and then later I want to tell the API which of those paths it should
actually modify.
This is to let the user choose which paths to modify and which ones not.
OK, well the issue #3434
Stefan Küng wrote:
> On 10.03.2010 17:23, Julian Foad wrote:
> > Hi, Stefan and Stefan.
> >
> > Stefan Sperling wrote:
> >> On Wed, Mar 10, 2010 at 01:19:37PM +, Julian Foad wrote:
> >>> Stefan Sperling wrote:
> On Wed, Mar 10, 2010 at 10:36:13AM +, Julian Foad wrote:
> > This patc
On 10.03.2010 17:23, Julian Foad wrote:
Hi, Stefan and Stefan.
Stefan Sperling wrote:
On Wed, Mar 10, 2010 at 01:19:37PM +, Julian Foad wrote:
Stefan Sperling wrote:
On Wed, Mar 10, 2010 at 10:36:13AM +, Julian Foad wrote:
This patch appears to have the filter reversed: it lets the u
Hi, Stefan and Stefan.
Stefan Sperling wrote:
> On Wed, Mar 10, 2010 at 01:19:37PM +, Julian Foad wrote:
> > Stefan Sperling wrote:
> > > On Wed, Mar 10, 2010 at 10:36:13AM +, Julian Foad wrote:
> > > > This patch appears to have the filter reversed: it lets the user specify
> > > > paths
On Wed, Mar 10, 2010 at 01:19:37PM +, Julian Foad wrote:
> Stefan Sperling wrote:
> > On Wed, Mar 10, 2010 at 10:36:13AM +, Julian Foad wrote:
> > > This patch appears to have the filter reversed: it lets the user specify
> > > paths that the filter should REMOVE, which IMO is not so useful
Stefan Sperling wrote:
> On Wed, Mar 10, 2010 at 10:36:13AM +, Julian Foad wrote:
> > This patch appears to have the filter reversed: it lets the user specify
> > paths that the filter should REMOVE, which IMO is not so useful.
>
> Why isn't that useful? I think either way (include and exclude
On Wed, Mar 10, 2010 at 10:36:13AM +, Julian Foad wrote:
> On Fri, 2010-03-05, s...@apache.org wrote:
> > Author: stsp
> > Date: Fri Mar 5 15:57:23 2010
> > New Revision: 919460
> >
> > URL: http://svn.apache.org/viewvc?rev=919460&view=rev
> > Log:
> > Fix issue #3434, "svn patch API should h
32 matches
Mail list logo
