Re: svn commit: r907414 - /subversion/trunk/subversion/libsvn_wc/questions.c

2010-02-08 Thread Stefan Sperling
On Mon, Feb 08, 2010 at 06:10:32PM -0500, Greg Stein wrote: > On Mon, Feb 8, 2010 at 18:06, Stefan Sperling wrote: > > On Mon, Feb 08, 2010 at 02:58:31PM -0500, Greg Stein wrote: > >> Invariably, a stream on a file will not be used > >> once it hits EOF > > > > Unless it implements mark/seek or re

Re: svn commit: r907414 - /subversion/trunk/subversion/libsvn_wc/questions.c

2010-02-08 Thread Greg Stein
On Mon, Feb 8, 2010 at 18:06, Stefan Sperling wrote: > On Mon, Feb 08, 2010 at 02:58:31PM -0500, Greg Stein wrote: >> Invariably, a stream on a file will not be used >> once it hits EOF > > Unless it implements mark/seek or reset. See the patch code. Well aware of that. Read the reset of the thre

Re: svn commit: r907414 - /subversion/trunk/subversion/libsvn_wc/questions.c

2010-02-08 Thread Stefan Sperling
On Mon, Feb 08, 2010 at 02:58:31PM -0500, Greg Stein wrote: > Invariably, a stream on a file will not be used > once it hits EOF Unless it implements mark/seek or reset. See the patch code. Stefan

Re: svn commit: r907414 - /subversion/trunk/subversion/libsvn_wc/questions.c

2010-02-08 Thread Greg Stein
by > design. > >  Bert > > - Oorspronkelijk bericht - > Van: Greg Stein > Verzonden: maandag 8 februari 2010 20:58 > Aan: dev@subversion.apache.org > Onderwerp: Re: svn commit: r907414 - > /subversion/trunk/subversion/libsvn_wc/questions.c > > On Sun, F

RE: svn commit: r907414 - /subversion/trunk/subversion/libsvn_wc/questions.c

2010-02-08 Thread Bert Huijben
The called function does an explicit disown so i assumed that behavior was by design. Bert - Oorspronkelijk bericht - Van: Greg Stein Verzonden: maandag 8 februari 2010 20:58 Aan: dev@subversion.apache.org Onderwerp: Re: svn commit: r907414 - /subversion/trunk/subversion/libsvn_wc

Re: svn commit: r907414 - /subversion/trunk/subversion/libsvn_wc/questions.c

2010-02-08 Thread Greg Stein
On Sun, Feb 7, 2010 at 06:50, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/questions.c Sun Feb  7 11:50:50 2010 > @@ -367,12 +367,15 @@ >       return SVN_NO_ERROR; >     } > > +  SVN_ERR(err); > + >   /* Check all bytes, and verify checksum if requested. */ > -  SVN_ERR(compare_and_ve